From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 4/5] pinctrl: samsung: fix leaked of_node references Date: Fri, 12 Apr 2019 09:12:45 +0200 Message-ID: References: <1555048943-39589-1-git-send-email-wen.yang99@zte.com.cn> <1555048943-39589-5-git-send-email-wen.yang99@zte.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1555048943-39589-5-git-send-email-wen.yang99@zte.com.cn> Sender: linux-kernel-owner@vger.kernel.org To: Wen Yang Cc: linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn, Linus Walleij , Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Kukjin Kim , "linux-samsung-soc@vger.kernel.org" , linux-gpio@vger.kernel.org List-Id: linux-gpio@vger.kernel.org On Fri, 12 Apr 2019 at 08:01, Wen Yang wrote: > > The call to of_find_compatible_node returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./drivers/pinctrl/samsung/pinctrl-exynos-arm.c:76:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. > ./drivers/pinctrl/samsung/pinctrl-exynos-arm.c:82:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof