From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v6] platform/x86: Add driver for ACPI INT0002 Virtual GPIO device Date: Thu, 8 Jun 2017 19:15:39 +0200 Message-ID: References: <20170602151507.22391-1-hdegoede@redhat.com> <20170602151507.22391-2-hdegoede@redhat.com> <20170608154541.GH32509@fury> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-it0-f67.google.com ([209.85.214.67]:35782 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132AbdFHRPk (ORCPT ); Thu, 8 Jun 2017 13:15:40 -0400 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Hans de Goede Cc: Darren Hart , Andy Shevchenko , "Rafael J . Wysocki" , Linus Walleij , Alexandre Courbot , "linux-acpi@vger.kernel.org" , Platform Driver , Andy Shevchenko , "linux-gpio@vger.kernel.org" , joeyli , Takashi Iwai On Thu, Jun 8, 2017 at 6:45 PM, Hans de Goede wrote: > Hi, > > On 06/08/2017 05:45 PM, Darren Hart wrote: >> >> On Wed, Jun 07, 2017 at 05:53:38PM +0300, Andy Shevchenko wrote: >>> >>> On Fri, Jun 2, 2017 at 6:15 PM, Hans de Goede >>> wrote: >>>> >>>> Some peripherals on Bay Trail and Cherry Trail platforms signal a >>>> Power Management Event (PME) to the Power Management Controller (PMC) >>>> to wakeup the system. When this happens software needs to explicitly >>>> clear the PME bus 0 status bit in the GPE0a_STS register to avoid an >>>> IRQ storm on IRQ 9. >>>> >>>> This is modelled in ACPI through the INT0002 ACPI device, which is >>>> called a "Virtual GPIO controller" in ACPI because it defines the >>>> event handler to call when the PME triggers through _AEI and _L02 >>>> methods as would be done for a real GPIO interrupt in ACPI. >>>> >>>> This commit adds a driver which registers the Virtual GPIOs expected >>>> by the DSDT on these devices, letting gpiolib-acpi claim the >>>> virtual GPIO and install a GPIO-interrupt handler which call the _L02 >>>> handler as it would for a real GPIO controller. >>>> >>> >>> Pushed to testing w/o Linus' tag (there is no one yet) >> >> >> Will you be taking this through fixes Andy? For a 4.12-rc* target per >> Hans' >> response to the cover letter? > > > Note that Rafael is planning to drop (revert) the commit which makes > it (extra) desirable for this driver to get into 4.12, so we should > perhaps reconsider that. I'm fine either way, but the primary reason > to push this as a fix for 4.12 is no longer valid AFAICT. Maybe I will just queue it up along with this series: http://marc.info/?l=linux-kernel&m=149688087904433&w=2 if Andy and Darren agree? Thanks, Rafael