From: Sonic Zhang <sonic.adi@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Sonic Zhang <sonic.zhang@analog.com>,
Steven Miao <realmz6@gmail.com>,
adi-buildroot-devel@lists.sourceforge.net
Subject: Re: [PATCH 34/54] blackfin: gpio: Be sure to clamp return value
Date: Thu, 24 Dec 2015 17:06:59 +0800 [thread overview]
Message-ID: <CAJxxZ0MeHF0wraVj7XRjb85bWawOSULZ356C67W0gnmEWABbag@mail.gmail.com> (raw)
In-Reply-To: <1450795086-27238-1-git-send-email-linus.walleij@linaro.org>
Acked-by: Sonic Zhang <sonic.zhang@analog.com>
On Tue, Dec 22, 2015 at 10:38 PM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
>
> Cc: Sonic Zhang <sonic.zhang@analog.com>
> Cc: Steven Miao <realmz6@gmail.com>
> Cc: adi-buildroot-devel@lists.sourceforge.net
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Blackfin folks: as mentioned in 00/54: either apply this directly
> or ACK it and I will take it into the GPIO tree.
> ---
> arch/blackfin/kernel/bfin_gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/blackfin/kernel/bfin_gpio.c b/arch/blackfin/kernel/bfin_gpio.c
> index a017359c1826..84baa6217c03 100644
> --- a/arch/blackfin/kernel/bfin_gpio.c
> +++ b/arch/blackfin/kernel/bfin_gpio.c
> @@ -1159,7 +1159,7 @@ static int bfin_gpiolib_direction_output(struct gpio_chip *chip, unsigned gpio,
>
> static int bfin_gpiolib_get_value(struct gpio_chip *chip, unsigned gpio)
> {
> - return bfin_gpio_get_value(gpio);
> + return !!bfin_gpio_get_value(gpio);
> }
>
> static void bfin_gpiolib_set_value(struct gpio_chip *chip, unsigned gpio, int value)
> --
> 2.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-12-24 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 14:38 [PATCH 34/54] blackfin: gpio: Be sure to clamp return value Linus Walleij
2015-12-24 9:06 ` Sonic Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJxxZ0MeHF0wraVj7XRjb85bWawOSULZ356C67W0gnmEWABbag@mail.gmail.com \
--to=sonic.adi@gmail.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=realmz6@gmail.com \
--cc=sonic.zhang@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).