* [PATCH 2/2] led: remove use of gpiochip_remove() retval
@ 2014-09-30 14:35 Pramod Gurav
2014-09-30 21:21 ` Bryan Wu
0 siblings, 1 reply; 4+ messages in thread
From: Pramod Gurav @ 2014-09-30 14:35 UTC (permalink / raw)
To: linux-kernel
Cc: Pramod Gurav, Linus Walleij, Alexandre Courbot, Bryan Wu,
Richard Purdie, linux-leds, linux-gpio
Get rid of using return value from gpiochip_remove() as it returns
void.
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Bryan Wu <cooloney@gmail.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: linux-leds@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
---
drivers/leds/leds-pca9532.c | 10 ++--------
drivers/leds/leds-tca6507.c | 7 ++-----
2 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
index 4a0e786..5a6363d 100644
--- a/drivers/leds/leds-pca9532.c
+++ b/drivers/leds/leds-pca9532.c
@@ -319,14 +319,8 @@ static int pca9532_destroy_devices(struct pca9532_data *data, int n_devs)
}
#ifdef CONFIG_LEDS_PCA9532_GPIO
- if (data->gpio.dev) {
- int err = gpiochip_remove(&data->gpio);
- if (err) {
- dev_err(&data->client->dev, "%s failed, %d\n",
- "gpiochip_remove()", err);
- return err;
- }
- }
+ if (data->gpio.dev)
+ gpiochip_remove(&data->gpio);
#endif
return 0;
diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
index 3d9e267..20fa8e7 100644
--- a/drivers/leds/leds-tca6507.c
+++ b/drivers/leds/leds-tca6507.c
@@ -667,11 +667,8 @@ static int tca6507_probe_gpios(struct i2c_client *client,
static void tca6507_remove_gpio(struct tca6507_chip *tca)
{
- if (tca->gpio.ngpio) {
- int err = gpiochip_remove(&tca->gpio);
- dev_err(&tca->client->dev, "%s failed, %d\n",
- "gpiochip_remove()", err);
- }
+ if (tca->gpio.ngpio)
+ gpiochip_remove(&tca->gpio);
}
#else /* CONFIG_GPIOLIB */
static int tca6507_probe_gpios(struct i2c_client *client,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] led: remove use of gpiochip_remove() retval
2014-09-30 14:35 [PATCH 2/2] led: remove use of gpiochip_remove() retval Pramod Gurav
@ 2014-09-30 21:21 ` Bryan Wu
2014-10-02 7:12 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: Bryan Wu @ 2014-09-30 21:21 UTC (permalink / raw)
To: Pramod Gurav
Cc: lkml, Linus Walleij, Alexandre Courbot, Richard Purdie,
Linux LED Subsystem, linux-gpio@vger.kernel.org
On Tue, Sep 30, 2014 at 7:35 AM, Pramod Gurav
<pramod.gurav@smartplayin.com> wrote:
> Get rid of using return value from gpiochip_remove() as it returns
> void.
>
Looks good to me. I will merge it.
But what's in the first patch. I just got this second patch in my email inbox.
-Bryan
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: linux-leds@vger.kernel.org
>
> Cc: linux-gpio@vger.kernel.org
>
> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
> ---
> drivers/leds/leds-pca9532.c | 10 ++--------
> drivers/leds/leds-tca6507.c | 7 ++-----
> 2 files changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
> index 4a0e786..5a6363d 100644
> --- a/drivers/leds/leds-pca9532.c
> +++ b/drivers/leds/leds-pca9532.c
> @@ -319,14 +319,8 @@ static int pca9532_destroy_devices(struct pca9532_data *data, int n_devs)
> }
>
> #ifdef CONFIG_LEDS_PCA9532_GPIO
> - if (data->gpio.dev) {
> - int err = gpiochip_remove(&data->gpio);
> - if (err) {
> - dev_err(&data->client->dev, "%s failed, %d\n",
> - "gpiochip_remove()", err);
> - return err;
> - }
> - }
> + if (data->gpio.dev)
> + gpiochip_remove(&data->gpio);
> #endif
>
> return 0;
> diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
> index 3d9e267..20fa8e7 100644
> --- a/drivers/leds/leds-tca6507.c
> +++ b/drivers/leds/leds-tca6507.c
> @@ -667,11 +667,8 @@ static int tca6507_probe_gpios(struct i2c_client *client,
>
> static void tca6507_remove_gpio(struct tca6507_chip *tca)
> {
> - if (tca->gpio.ngpio) {
> - int err = gpiochip_remove(&tca->gpio);
> - dev_err(&tca->client->dev, "%s failed, %d\n",
> - "gpiochip_remove()", err);
> - }
> + if (tca->gpio.ngpio)
> + gpiochip_remove(&tca->gpio);
> }
> #else /* CONFIG_GPIOLIB */
> static int tca6507_probe_gpios(struct i2c_client *client,
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] led: remove use of gpiochip_remove() retval
2014-09-30 21:21 ` Bryan Wu
@ 2014-10-02 7:12 ` Linus Walleij
2014-10-03 17:15 ` Bryan Wu
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2014-10-02 7:12 UTC (permalink / raw)
To: Bryan Wu
Cc: Pramod Gurav, lkml, Alexandre Courbot, Richard Purdie,
Linux LED Subsystem, linux-gpio@vger.kernel.org
On Tue, Sep 30, 2014 at 11:21 PM, Bryan Wu <cooloney@gmail.com> wrote:
> On Tue, Sep 30, 2014 at 7:35 AM, Pramod Gurav
> <pramod.gurav@smartplayin.com> wrote:
>> Get rid of using return value from gpiochip_remove() as it returns
>> void.
>
> Looks good to me. I will merge it.
Please don't.
The issue is already fixed through the GPIO tree, where the
API change is.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] led: remove use of gpiochip_remove() retval
2014-10-02 7:12 ` Linus Walleij
@ 2014-10-03 17:15 ` Bryan Wu
0 siblings, 0 replies; 4+ messages in thread
From: Bryan Wu @ 2014-10-03 17:15 UTC (permalink / raw)
To: Linus Walleij
Cc: Pramod Gurav, lkml, Alexandre Courbot, Richard Purdie,
Linux LED Subsystem, linux-gpio@vger.kernel.org
On Thu, Oct 2, 2014 at 12:12 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Sep 30, 2014 at 11:21 PM, Bryan Wu <cooloney@gmail.com> wrote:
>> On Tue, Sep 30, 2014 at 7:35 AM, Pramod Gurav
>> <pramod.gurav@smartplayin.com> wrote:
>>> Get rid of using return value from gpiochip_remove() as it returns
>>> void.
>>
>> Looks good to me. I will merge it.
>
> Please don't.
>
> The issue is already fixed through the GPIO tree, where the
> API change is.
>
Oh, really. I wasn't aware that. Let me drop this change then.
Thanks,
-Bryan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-03 17:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-30 14:35 [PATCH 2/2] led: remove use of gpiochip_remove() retval Pramod Gurav
2014-09-30 21:21 ` Bryan Wu
2014-10-02 7:12 ` Linus Walleij
2014-10-03 17:15 ` Bryan Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).