From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Subject: Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller Date: Fri, 20 May 2016 13:30:10 +0900 Message-ID: References: <1436841787-7734-1-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Alexandre Courbot List-Id: linux-gpio@vger.kernel.org Hi Linus, 2015-07-16 16:48 GMT+09:00 Masahiro Yamada : > Hi Linus, > > OK, I will do it in v4. I has been away from my GPIO driver upstreaming for a long time for some reason. I sent v3 ten months ago. http://patchwork.ozlabs.org/patch/494860/ In the meantime, there have been various updates in the GPIO frame-work. So, I'd like to know the recommended driver coding style based on 4.7-rc1. Diving into the git-log so far, I came up the following list: [1] The "dev" member of gpiochip was renamed to "parent" [2] The most recommended register function is now devm_gpiochip_add_data() [3] Pass the driver private data to the 3rd argument of devm_gpiochip_add_data(). [4] Do not use container_of() to covert from gpiochip to driver private data. Instead, gpiochip_get_data() should be used. (I used of_mm_gpio_chip in v3, but I needed to use container_of() to convert from gpiochip to of_mm_gpio_chip. I am wondering if you are happy with it or not.) [5] gpiochip.owner is being deprecated. So, platform drivers need not set "gpiochip.owner = THIS_MODULE". Correct? Is there anything else missing? Any advice is appreciated. -- Best Regards Masahiro Yamada