From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48572C433E0 for ; Fri, 12 Feb 2021 11:01:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 188C164E65 for ; Fri, 12 Feb 2021 11:01:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230063AbhBLLAo (ORCPT ); Fri, 12 Feb 2021 06:00:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:58138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231189AbhBLLA0 (ORCPT ); Fri, 12 Feb 2021 06:00:26 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D633C64E74; Fri, 12 Feb 2021 10:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613127586; bh=dOd1zYO5Nn3XjGlskgniasDG7qC1K106t/ncttY1SFA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KlAVFzmQf3dRDjZ2VsKc44xbxM2HVM/xXANy9/mH1Lc0Q7gaHr+sbt4eB6rFecAXi U/SK+fCbHjCaJXw7fANSRhSs+VlTWmg0PBjla2sPFNocvgPAPOHo3kEKrjH5AZsbcf H+BmHbGqD6N0E/SALcfMDaJRtcZF7T7OFe/uKbDmX33B5SLdsASL+o63Y0QWSaOhR/ I6FzmTGjkv/NpdA8GGFSl6MflzsyNONm4VsPvJMIMMLGdt1hEQpWO6i/vsa7F1ZaKO FsfrjUKnOgx5unHMmNsvvREV4y8LjLSVaZhB6Q0vTWt/665XD3dJoTa/1Eh9bWTWOV BXI+p/GofGp9w== Received: by mail-ot1-f48.google.com with SMTP id d7so7995803otq.6; Fri, 12 Feb 2021 02:59:45 -0800 (PST) X-Gm-Message-State: AOAM533fT7KiO2JbsVB3GUbxHK58lRu67zKrlcWCTsdLiVOAM5ukRmCn 8Y0T5fGUXIQJrXfouELNyb4yFDUOlLWWZPuIUes= X-Google-Smtp-Source: ABdhPJxoCU52cPa6mMNIYZ4rlHNGHt0GAr1YboH3ddJ/xg8j+7AlHTLAAdZ5/goMW//JHfda63J+obB+1jMAxrX89dw= X-Received: by 2002:a9d:6c11:: with SMTP id f17mr1599122otq.210.1613127585105; Fri, 12 Feb 2021 02:59:45 -0800 (PST) MIME-Version: 1.0 References: <1612774577-55943-1-git-send-email-luojiaxing@huawei.com> <1612774577-55943-2-git-send-email-luojiaxing@huawei.com> <2a12cf7a21f74a0c9e2552a467b77fae@hisilicon.com> In-Reply-To: <2a12cf7a21f74a0c9e2552a467b77fae@hisilicon.com> From: Arnd Bergmann Date: Fri, 12 Feb 2021 11:59:28 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Linuxarm] Re: [PATCH for next v1 1/2] gpio: omap: Replace raw_spin_lock_irqsave with raw_spin_lock in omap_gpio_irq_handler() To: "Song Bao Hua (Barry Song)" Cc: Grygorii Strashko , luojiaxing , Linus Walleij , Andy Shevchenko , Andy Shevchenko , Santosh Shilimkar , Kevin Hilman , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , "linuxarm@openeuler.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Feb 12, 2021 at 11:42 AM Song Bao Hua (Barry Song) wrote: > > Ok, second thought. irqsave before generic_handle_irq() won't defeat > the purpose of preemption too much as the dispatched irq handlers by > gpiochip will run in their own threads but not in the thread of > gpiochip's handler. > > so looks like this patch can improve by: > * move other raw_spin_lock_irqsave to raw_spin_lock; > * keep the raw_spin_lock_irqsave before generic_handle_irq() to mute > the warning in genirq. It seems that the other drivers just call handle_nested_irq() instead of generic_handle_irq(). Arnd