From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 086DAC4338F for ; Mon, 23 Aug 2021 01:22:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E28CD6135D for ; Mon, 23 Aug 2021 01:22:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234639AbhHWBXe (ORCPT ); Sun, 22 Aug 2021 21:23:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234465AbhHWBXd (ORCPT ); Sun, 22 Aug 2021 21:23:33 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E76F1C061575 for ; Sun, 22 Aug 2021 18:22:51 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id d11so33390369eja.8 for ; Sun, 22 Aug 2021 18:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WYDJcPk27eaOYzRvmn3VXjqVNS8Lwk0NBihSR+O45KM=; b=nZYLHHjr5VkmwGK7MDgQNkIuvR9b708LZrDPVpVfiOfCaOsZc67/GF0ZTFXAn1YfFR 8QXLJ/bFLIE3ey2RE7gNjmdtcjSFVy1YeHyAfMIpxs8eI6tj7IZeS1Ax2rLB/DJ9u6eV cXCZIVmYemvhIbpyY4uzErf646Afut7PXBc6rC5QVTSjlDevFOwEAf3zp4uS95DzziGp 7lvKI3WBx4lSQgMFaofLbL+q1oYtmxSS+9AI8V+XN9CCs6NYICElUYvZLqpAg7SsS4Mv tSaLsbwGa4Gb2+cGjFUH0D+Z7l4iIepsGKUNbUeJKsWhQDYnTpT7ltRBncOVF8fQQp43 WN+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WYDJcPk27eaOYzRvmn3VXjqVNS8Lwk0NBihSR+O45KM=; b=efMg4yzU+YK2SNJIm/D/GlSPyNWkzD8PNfK+NoBnHmP1HtH6wVxYwJL/dGCzEADe/z pFGYwV18yyqToSlhrbeYqsSiJUBCvBtfc48xMLhVjoko4skbVBUE3MlItHLE8xzn9iJx AILkmL0hEtPYDirEgloPISv8Fej3SfM9wlxkPtl0Kcqc/+2sVKjmxs1ph9c54+V7CL8q cjTrE7wX1xc+iCLT0oQ3UFjsvKWdEvUBz6x3syuRidI9nYDzDU/Fxkg5IO/ht/WA5iG3 tyjQ1x9GBPax3vdF8EM4GdHT9GtetQ7d6C8Z//Aa5OCO6WjaE/RqQEdyPKVyCzAq947R EuSA== X-Gm-Message-State: AOAM533xprDj6wWGsJgt33NQ4nTpqg+2jd5MHpKlgXviZzJe/jGwJUqW 6AFBfAXjWZfydLwI4I2pq4DqdEnsxo0jwfTig2UvVg== X-Google-Smtp-Source: ABdhPJw6n+mH08Xf6OE4yaoX37ooGQf1hGFMgsgeCuMYD5FoyBZzpgVOJVBPL9zW75eYcv5s/Is2jMQ3RdsUuC5Q3Gs= X-Received: by 2002:a17:906:b25a:: with SMTP id ce26mr1428510ejb.174.1629681770527; Sun, 22 Aug 2021 18:22:50 -0700 (PDT) MIME-Version: 1.0 References: <20210329015938.20316-1-brad@pensando.io> <20210329015938.20316-2-brad@pensando.io> In-Reply-To: From: Brad Larson Date: Sun, 22 Aug 2021 18:22:39 -0700 Message-ID: Subject: Re: [PATCH v2 01/13] gpio: Add Elba SoC gpio driver for spi cs control To: Andy Shevchenko Cc: linux-arm Mailing List , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , devicetree , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Andy, On Mon, Mar 29, 2021 at 3:41 AM Andy Shevchenko wrote: > > On Mon, Mar 29, 2021 at 5:01 AM Brad Larson wrote: > > > > This GPIO driver is for the Pensando Elba SoC which > > provides control of four chip selects on two SPI busses. [...] > > +MODULE_LICENSE("GPL v2"); > > +MODULE_DESCRIPTION("Pensando Elba SoC SPI chip-select driver"); > > It's funny, you told it can't be a module and you add a dead code. Be > somehow consistent, please. Yes the code was not consistent with statement that the module cannot being loadable in my reply. I had not used builtin_platform_driver() previously. The updated patchset will be changed to this for the driver. -module_platform_driver(elba_spics_driver); - -MODULE_LICENSE("GPL v2"); -MODULE_DESCRIPTION("Elba SPI chip-select driver"); +builtin_platform_driver(elba_spics_driver); where drivers/gpio/Kconfig could be changed to this --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -241,10 +241,8 @@ config GPIO_EIC_SPRD Say yes here to support Spreadtrum EIC device. config GPIO_ELBA_SPICS - bool "Pensando Elba SPI chip-select" + def_bool y depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST - help - Say yes here to support the Pensando Elba SoC SPI chip-select driver Regards, Brad