linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Tengfei Fan <quic_tengfan@quicinc.com>
Cc: andersson@kernel.org, konrad.dybcio@linaro.org,
	linus.walleij@linaro.org,  krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org,  linux-arm-msm@vger.kernel.org,
	linux-gpio@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: update compatible name for match with driver
Date: Fri, 8 Mar 2024 14:10:34 -0600	[thread overview]
Message-ID: <CAL_JsqLbbRFijBXS5CyRm0P4FMY7bR3UUdgXA7xP4Z1oRevnzQ@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqJfsWaj9OPkvc34rBvx7W_3v9+1kZqNu6QKDsA=iWAA4w@mail.gmail.com>

On Tue, Feb 27, 2024 at 7:37 AM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Mon, Jan 29, 2024 at 3:25 AM Tengfei Fan <quic_tengfan@quicinc.com> wrote:
> >
> > Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl"
> > to match the compatible name in sm4450 pinctrl driver.
> >
> > Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl")
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> > ---
> >  Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
> > index bb08ca5a1509..bb675c8ec220 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
> > @@ -17,7 +17,7 @@ allOf:
> >
> >  properties:
> >    compatible:
> > -    const: qcom,sm4450-pinctrl
> > +    const: qcom,sm4450-tlmm
>
> I think you forgot to update the example:
>
> Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.example.dtb:
> /example-0/pinctrl@f100000: failed to match any schema with
> compatible: ['qcom,sm4450-tlmm']

Still a warning in linux-next. Please send a fix.

Rob

  reply	other threads:[~2024-03-08 20:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29  9:25 [PATCH v2 0/2] update SM4450 pinctrl document Tengfei Fan
2024-01-29  9:25 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom: update compatible name for match with driver Tengfei Fan
2024-01-29 11:22   ` Krzysztof Kozlowski
2024-02-27 13:37   ` Rob Herring
2024-03-08 20:10     ` Rob Herring [this message]
2024-03-09 23:44       ` Linus Walleij
2024-03-11  2:27         ` Tengfei Fan
2024-03-11  6:48           ` Krzysztof Kozlowski
2024-03-11  9:43             ` Tengfei Fan
2024-03-11  9:58               ` Krzysztof Kozlowski
2024-03-09 23:44   ` Linus Walleij
2024-01-29  9:25 ` [PATCH v2 2/2] dt-bindings: pinctrl: qcom: consolidate functions to " Tengfei Fan
2024-01-29 11:24   ` Krzysztof Kozlowski
2024-01-31  8:24     ` Tengfei Fan
2024-01-31  8:34       ` Krzysztof Kozlowski
2024-01-31  8:40         ` Tengfei Fan
2024-01-30  4:38   ` Bjorn Andersson
2024-01-31  8:28     ` Tengfei Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqLbbRFijBXS5CyRm0P4FMY7bR3UUdgXA7xP4Z1oRevnzQ@mail.gmail.com \
    --to=robh+dt@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@quicinc.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_tengfan@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).