From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96E93CA0FE1 for ; Fri, 1 Sep 2023 09:34:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244441AbjIAJei (ORCPT ); Fri, 1 Sep 2023 05:34:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348829AbjIAJeh (ORCPT ); Fri, 1 Sep 2023 05:34:37 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC5BB10E5 for ; Fri, 1 Sep 2023 02:34:34 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2bd0bc8b429so31806381fa.2 for ; Fri, 01 Sep 2023 02:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1693560873; x=1694165673; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XirWmBwg/Ps6jm5whQ65EEWIWZF91+vzUx+/E2s51pQ=; b=J23iZpJkES/VUJ7DNJV096hgvdn96ucer08ETRghheKoBcRJNVf2VzUPaXFPTsqG52 6uRZAqOQpI7OdFD/NN8XyhrtrTWSrVPfYU33KunwCKETuGrevhUkqHkYrXgw3zNtZqQe WCXR0HncPdKbEfKLcMdwvUwVFaqj2XxWHY7jd1BEi8scUiTnHXy2oEwPcbC+wZC/SiU2 IWFVjmj+eRX1MDEC3+qUM/QHaXN2TtCJTUiyOw780MTrGUAilxaj3CUDO7Ba/EM7IeE6 Pf+0zkq7W65efB5QdeEs1w14tLGoe0kQLcMIebqUPaViSHNNwz8Tcfh9YJ2AuWs7oDGm CGZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693560873; x=1694165673; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XirWmBwg/Ps6jm5whQ65EEWIWZF91+vzUx+/E2s51pQ=; b=OntEeiO8nxWRPQo3GzPwZMHrDgu4vK5itD7vUnB2tVc9XsdO2MkXvvncmojQ69Ov9X bDtj0ECZPo+qjMH0b1k3bLktt5VHMbF6+7Okl27A1r0P+A9m3go9bHGmXomo6RyGQmDr zokg7bGGJxdn8dJpo8hcUrIkOAUTSH8Kh2owVF4UcDB31UpJIMn7+8Jn6+hKCJSUgKbh wBWAm0zeur0elaPnjCJtFZzzxEAnLv3ZNgA1feprN0yldWIvDM68KslMM8bPBZh0GyMt CfCsP74ECBNxaM8bUlExgVy09y7MGm1qG46iLuTHC6kzeaX9SqMdY4xew8yebJH28pR5 0H2Q== X-Gm-Message-State: AOJu0YzKo6dWK56A7O2ZBgAhhroZOPezJ2zqDl27cNGEN0A6Pw2oXKn1 vBjA4entn2OjjuUpcMtPn0ciAhbu1xa5/6QOEpmaIw== X-Google-Smtp-Source: AGHT+IFUWbRjlXU+fqBN7/hSZyksdmm1qMKqdHFpEmgoh4f1PYmGNp7sg7sgvJA3SvmREz9zF2NQrIifQ15n4XazxZI= X-Received: by 2002:a2e:9619:0:b0:2b9:ecab:d924 with SMTP id v25-20020a2e9619000000b002b9ecabd924mr1338502ljh.18.1693560873039; Fri, 01 Sep 2023 02:34:33 -0700 (PDT) MIME-Version: 1.0 References: <20230831194934.19628-1-brgl@bgdev.pl> In-Reply-To: From: Bartosz Golaszewski Date: Fri, 1 Sep 2023 11:34:20 +0200 Message-ID: Subject: Re: [RFT PATCH] spi: bcm2835: reduce the abuse of the GPIO API To: Linus Walleij Cc: Andy Shevchenko , Lukas Wunner , Mark Brown , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Sep 1, 2023 at 11:22=E2=80=AFAM Linus Walleij wrote: > > On Fri, Sep 1, 2023 at 10:55=E2=80=AFAM Andy Shevchenko > wrote: > > > > I'm not sure this is a good candidate for the GPIOLIB quirks. This is > > > the SPI setup callback (which makes me think - I should have used > > > gpiod_get(), not devm_gpiod_get() and then put the descriptor in > > > .cleanup()) and not probe. It would be great to get some background o= n > > > why this is even needed in the first place. The only reason I see is > > > booting the driver with an invalid device-tree that doesn't assign th= e > > > GPIO to the SPI controller. > > > > Maybe Lukas knows more? > > He does! > The background can be found here: > https://www.spinics.net/lists/linux-gpio/msg36218.html > (hm this "spinics" archive should be imported to lore...) > > Yours, > Linus Walleij Thanks! I will fix the patch and add this link to the commit message. Bart