From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Anson Huang <Anson.Huang@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
NXP Linux Team <Linux-imx@nxp.com>
Subject: Re: [PATCH] gpio: mxc: add power management support
Date: Fri, 13 Jul 2018 09:19:37 +0200 [thread overview]
Message-ID: <CAMRc=McQdbZbd3GDdgi6paKFUXSJTb_3nRG3npzMQs=FEwN2ew@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdaKQ_Lg=t3DLsvXQNLwi=BYugqNGyssEM9Hn2Ss5r-kQw@mail.gmail.com>
2018-07-13 9:11 GMT+02:00 Linus Walleij <linus.walleij@linaro.org>:
> On Tue, Jul 10, 2018 at 9:53 AM Anson Huang <Anson.Huang@nxp.com> wrote:
>
>> GPIO registers could lose context on some i.MX SoCs,
>> like on i.MX7D, when enter LPSR mode, the whole SoC
>> will be powered off except LPSR domain, GPIO banks
>> will lose context in this case, need to restore
>> the context after resume from LPSR mode.
>>
>> This patch adds GPIO save/restore for those necessary
>> registers, and put the save/restore operations in noirq
>> suspend/resume phase, since GPIO is fundamental module
>> which could be used by other peripherals' resume phase.
>>
>> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
>
> Hoping for some review on this before applying...
> Fabio? Bartosz?
>
> Yours,
> Linus Walleij
I'm not familiar with these SoCs but the code looks good and clean to me.
Reviewed-by: Bartosz Golaszewski <brgl@bgdev.pl>
next prev parent reply other threads:[~2018-07-13 7:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 7:48 [PATCH] gpio: mxc: add power management support Anson Huang
2018-07-13 7:11 ` Linus Walleij
2018-07-13 7:19 ` Bartosz Golaszewski [this message]
2018-07-13 17:57 ` Fabio Estevam
2018-07-13 18:33 ` Fabio Estevam
2018-07-14 1:53 ` Anson Huang
2018-07-14 16:13 ` Fabio Estevam
2018-07-16 6:14 ` Anson Huang
2018-07-17 13:43 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=McQdbZbd3GDdgi6paKFUXSJTb_3nRG3npzMQs=FEwN2ew@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).