From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Rob Herring <robh@kernel.org>,
Frank Rowand <frank.rowand@sony.com>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v3 1/2] of: unittest: Switch to use fwnode instead of of_node
Date: Wed, 29 Jun 2022 20:50:28 +0200 [thread overview]
Message-ID: <CAMRc=MccLs3SNp30d=fPEim8r1q3nPda5USnbM08dYNJA_VL3A@mail.gmail.com> (raw)
In-Reply-To: <20220629115010.10538-1-andriy.shevchenko@linux.intel.com>
On Wed, Jun 29, 2022 at 1:50 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> GPIO library now accepts fwnode as a firmware node, so
> switch the module to use it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v3: no changes
> drivers/of/unittest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 7f6bba18c515..5a842dfc27e8 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -1602,7 +1602,7 @@ static int unittest_gpio_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, devptr);
>
> - devptr->chip.of_node = pdev->dev.of_node;
> + devptr->chip.fwnode = dev_fwnode(&pdev->dev);
> devptr->chip.label = "of-unittest-gpio";
> devptr->chip.base = -1; /* dynamic allocation */
> devptr->chip.ngpio = 5;
> @@ -1611,7 +1611,7 @@ static int unittest_gpio_probe(struct platform_device *pdev)
> ret = gpiochip_add_data(&devptr->chip, NULL);
>
> unittest(!ret,
> - "gpiochip_add_data() for node @%pOF failed, ret = %d\n", devptr->chip.of_node, ret);
> + "gpiochip_add_data() for node @%pfw failed, ret = %d\n", devptr->chip.fwnode, ret);
>
> if (!ret)
> unittest_gpio_probe_pass_count++;
> --
> 2.35.1
>
Reviewed-by: Bartosz Golaszewski <brgl@bgdev.pl>
next prev parent reply other threads:[~2022-06-29 18:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 11:50 [PATCH v3 1/2] of: unittest: Switch to use fwnode instead of of_node Andy Shevchenko
2022-06-29 11:50 ` [PATCH v3 2/2] of: unittest: make unittest_gpio_remove() consistent with unittest_gpio_probe() Andy Shevchenko
2022-06-29 18:50 ` Bartosz Golaszewski [this message]
2022-06-30 16:27 ` [PATCH v3 1/2] of: unittest: Switch to use fwnode instead of of_node Rob Herring
2022-06-30 19:02 ` Andy Shevchenko
2022-06-30 21:34 ` Rob Herring
2022-06-30 21:37 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MccLs3SNp30d=fPEim8r1q3nPda5USnbM08dYNJA_VL3A@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=frank.rowand@sony.com \
--cc=frowand.list@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).