From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Kent Gibson <warthog618@gmail.com>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Robert Thomas <rob.thomas@raspberrypi.com>
Subject: Re: [libgpiod][PATCH] bindings: python: fix __repr__() implementations
Date: Mon, 5 Feb 2024 10:18:40 +0100 [thread overview]
Message-ID: <CAMRc=McqAnYOOuH_dG7CZfty==r1avfyaPWK+oLiTHs3yn0YEg@mail.gmail.com> (raw)
In-Reply-To: <20240202130806.36334-1-brgl@bgdev.pl>
On Fri, Feb 2, 2024 at 2:08 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The __repr__() function should - if possible - return a valid Python
> expression that can be used to instantiate a new object when evaluated.
>
> LineSettings.__repr__() is missing comas between arguments. Both Chip and
> LineSettings also don't prefix the returned string with 'gpiod.'. Fix
> both functions and add more test cases - including actually using the
> strings returned by __repr__() to create new objects and compare their
> contents.
>
> Reported-by: Robert Thomas <rob.thomas@raspberrypi.com>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
Patch applied.
Bart
prev parent reply other threads:[~2024-02-05 9:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 13:08 [libgpiod][PATCH] bindings: python: fix __repr__() implementations Bartosz Golaszewski
2024-02-05 9:18 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=McqAnYOOuH_dG7CZfty==r1avfyaPWK+oLiTHs3yn0YEg@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=rob.thomas@raspberrypi.com \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).