From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09328C4332F for ; Wed, 9 Nov 2022 13:13:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229499AbiKINN1 (ORCPT ); Wed, 9 Nov 2022 08:13:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbiKINN0 (ORCPT ); Wed, 9 Nov 2022 08:13:26 -0500 Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB41EE21 for ; Wed, 9 Nov 2022 05:13:25 -0800 (PST) Received: by mail-vk1-xa33.google.com with SMTP id g26so10971011vkm.12 for ; Wed, 09 Nov 2022 05:13:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+xGpBG68yF08lFUOD8FBdV6g+IPjUuqkuqMR+0AcmSk=; b=Y15zyMu5aj0OdVFCG2o69gYSzZu8TjRpqnGEAOUbLWgV8/N3lcgs6OLiOUGYsksj8T 1H5ymxeAJt+w9z+BfBjUpEf++Ps7GDZULzl0y+SVk0rGrs/AJLhZUFaaolqQG9wWqrN1 ie5IFmKCDXaqb5fXj3pWCd4A6aXlLSpq2plpJR0S1lDTvxkRiQdM5IVEyxhz9yQ4aOB6 WOEw9sk/87nuFTr0OHku6N1YreSM4POJYQ3mJtO+e6UIu/IoejNCovvtZBXMeiaoQje1 JqgFyQzgMc9ZEWQqn4+jZhCtzNwW6BibzCrq+doTz2I8cHtKMPcSivo0Ateq6M4PXGIv 19fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+xGpBG68yF08lFUOD8FBdV6g+IPjUuqkuqMR+0AcmSk=; b=QZTKNF9FRl3htLC5EpU9dQlLdGZTt0QeBEmwdGlJC4xQ5F0kWiSo1egFNm4ElW1E01 ph2b+i1Slpi4O6XDSqhSrV6AVygA4u+I4GEHGH6cR7QkY6i65t82xYONtqLFavc6FKSq 5XLt3jDrJ0lG9wq+u7CyXevU112/OdtxhY2CnDQDEzXfVbUfoCA9Tco3/ceLZKKZ0W2T 2ihC3Bs1I76ynBz7g1RZARZnBfKZXUyebxu/s6ilswwtX5CsYhPQHlI95JYXO6Ta9iPI TVgsa45y6PPsabGouG8lUlqkP17kwEcvMtBQX6709pK+hODdoJfgQxPS6WL1eZgfiZpx 59qg== X-Gm-Message-State: ACrzQf0T7PWkaTdpJxM7CYS2U6XhhiKVsmeYs/kgawQGRLmd4gJXhjKl TP85iG/CiWAEBCsJbzbCSqGQXbUtypiDlBGBNo5wzw== X-Google-Smtp-Source: AMsMyM5aeaov7lpqDjWPDYQ2IhfUZRVLWjPERcWKtCe9KmX1ljQiJnMOLPgKrRur21mGztSmpgdFUq4KzpipyJbLj1M= X-Received: by 2002:a1f:a695:0:b0:3ab:85c0:e1e8 with SMTP id p143-20020a1fa695000000b003ab85c0e1e8mr13359359vke.1.1667999604912; Wed, 09 Nov 2022 05:13:24 -0800 (PST) MIME-Version: 1.0 References: <20221107161027.43384-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20221107161027.43384-1-andriy.shevchenko@linux.intel.com> From: Bartosz Golaszewski Date: Wed, 9 Nov 2022 14:13:14 +0100 Message-ID: Subject: Re: [PATCH v1 1/2] gpiolib: of: Prepare of_gpiochip_add() / of_gpiochip_remove() for fwnode To: Andy Shevchenko Cc: Dmitry Torokhov , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Nov 7, 2022 at 5:10 PM Andy Shevchenko wrote: > > GPIO library is getting rid of of_node, fwnode should be utilized instead. > Prepare of_gpiochip_add() / of_gpiochip_remove() for fwnode. > > Signed-off-by: Andy Shevchenko > --- > drivers/gpio/gpiolib-of.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c > index be9c34cca322..000020eb78d8 100644 > --- a/drivers/gpio/gpiolib-of.c > +++ b/drivers/gpio/gpiolib-of.c > @@ -1104,9 +1104,11 @@ static int of_gpiochip_add_pin_range(struct gpio_chip *chip) { return 0; } > > int of_gpiochip_add(struct gpio_chip *chip) > { > + struct device_node *np; > int ret; > > - if (!chip->of_node) > + np = to_of_node(chip->fwnode); > + if (!np) > return 0; > > if (!chip->of_xlate) { > @@ -1123,18 +1125,18 @@ int of_gpiochip_add(struct gpio_chip *chip) > if (ret) > return ret; > > - of_node_get(chip->of_node); > + fwnode_handle_get(chip->fwnode); > > ret = of_gpiochip_scan_gpios(chip); > if (ret) > - of_node_put(chip->of_node); > + fwnode_handle_put(chip->fwnode); > > return ret; > } > > void of_gpiochip_remove(struct gpio_chip *chip) > { > - of_node_put(chip->of_node); > + fwnode_handle_put(chip->fwnode); > } > > void of_gpio_dev_init(struct gpio_chip *gc, struct gpio_device *gdev) > -- > 2.35.1 > Applied, thanks! Bart