From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andrei Coardos <aboutphysycs@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
zhang.lyra@gmail.com, baolin.wang@linux.alibaba.com,
orsonzhai@gmail.com, andy@kernel.org, linus.walleij@linaro.org,
Alexandru Ardelean <alex@shruggie.ro>
Subject: Re: [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call
Date: Sat, 29 Jul 2023 16:07:26 +0200 [thread overview]
Message-ID: <CAMRc=MdBni3dRHjTvVeZ2idCFcd=xf6pNiF-DNurfdtSCPzX2g@mail.gmail.com> (raw)
In-Reply-To: <20230717121004.5205-1-aboutphysycs@gmail.com>
On Mon, Jul 17, 2023 at 2:10 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> The platform_set_drvdata() call was never used, ever since the driver was
> originally added.
> It looks like this copy+paste left-over. Possibly the author copied from a
> driver that had this line, but also had a remove hook.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/gpio/gpio-eic-sprd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
> index 84352a6f4973..53db88ae2a20 100644
> --- a/drivers/gpio/gpio-eic-sprd.c
> +++ b/drivers/gpio/gpio-eic-sprd.c
> @@ -653,7 +653,6 @@ static int sprd_eic_probe(struct platform_device *pdev)
> return ret;
> }
>
> - platform_set_drvdata(pdev, sprd_eic);
> return 0;
> }
>
> --
> 2.34.1
>
Applied, thanks!
Bart
prev parent reply other threads:[~2023-07-29 14:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 12:10 [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call Andrei Coardos
2023-07-17 14:05 ` Andy Shevchenko
2023-07-20 6:39 ` Baolin Wang
2023-07-29 14:07 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MdBni3dRHjTvVeZ2idCFcd=xf6pNiF-DNurfdtSCPzX2g@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=aboutphysycs@gmail.com \
--cc=alex@shruggie.ro \
--cc=andy@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).