From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0640C433DB for ; Tue, 9 Mar 2021 14:45:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A967265244 for ; Tue, 9 Mar 2021 14:45:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbhCIOpF (ORCPT ); Tue, 9 Mar 2021 09:45:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230446AbhCIOpD (ORCPT ); Tue, 9 Mar 2021 09:45:03 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFF15C06174A for ; Tue, 9 Mar 2021 06:45:02 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id bd6so20568588edb.10 for ; Tue, 09 Mar 2021 06:45:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z7cPUe6OpiGgg9pdWpzevNLk40pbl6JE13AQU/bZ3v8=; b=MganIBbRO7IGKoEuoVccoij+Wv/+3aOH7F3UWLU3mPTJH6E+K3iaLe7EbH/GMDI3s3 LgKrgVjT7oGk5OxmYHTx6InoToEjzhidCwwoGgelhjzfwY5mO/4StAg7Ws7PEqX7v7q6 vC1LKOKhK/IwCIhLCasdtxHcCd6n6/+eOdulCYQ6FCMV02VEz85iGswo9phAGsVqObOE o0N6dlEStLe07bi/PPBE3vMRV+BDDcU8eHY5LjgWpKgGpHKDmDo2GMPrLKnYuZnBdtQY TpRLTq/pP1ouJkFry04bbny1DxEMQ14Q2BzcOQtj7JOUv1v8QeGgTsNMUtt1O5EgPx0T p+UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z7cPUe6OpiGgg9pdWpzevNLk40pbl6JE13AQU/bZ3v8=; b=moYP2KsKy6PDnLnKdCkEtKiIBrIbQm9/1+BUzjdKvx98oTGIr5Z7ldXQZ0YPfaTCl2 Ufe7HXOrAW57Ykp1assihhuw7H99st+8OfyUOnKRowIeYJFXHgTgpV4VPIKC+x57SK0J rj0pe164qnsPSnNvpbxgkO6UcH9ZcENGKNVNN/pImtwJW3SRW44+aL7dDwFfTmk88fgl JMc1k7SO/8Fmqynyu/8m3wCrpU4GfXV+3xmpjP+zVOeCbVb/j19s3EFYIIugyXY7Exhx nRMcXlJB3BchHaR3Ybtsr3/+WdJpy9Z5HepLDRrXwgbNS9oJMFe4RAcS65lYSSlcNySc IM1w== X-Gm-Message-State: AOAM530W1eVciC0lfxehUvyCTWnqOazj6NL8uOOe3+icuAH4UH8yxs5W EgvIv3NqaaHjnnI9EDp32J6fLrmzN9BfgFajhCbPWQ== X-Google-Smtp-Source: ABdhPJzg1fajZ9DWjUm/eMv+Id4GYKrfIDnDcnYx9uM7tU0eHqqE174G+SOD5Q31WAyWGO53m+n6UULZqjIBCh+t7ZM= X-Received: by 2002:a05:6402:17d6:: with SMTP id s22mr4467758edy.232.1615301101579; Tue, 09 Mar 2021 06:45:01 -0800 (PST) MIME-Version: 1.0 References: <20210304102452.21726-1-brgl@bgdev.pl> <20210304102452.21726-6-brgl@bgdev.pl> In-Reply-To: From: Bartosz Golaszewski Date: Tue, 9 Mar 2021 15:44:50 +0100 Message-ID: Subject: Re: [PATCH v2 05/12] lib: bitmap: remove the 'extern' keyword from function declarations To: Andy Shevchenko Cc: Joel Becker , Christoph Hellwig , Shuah Khan , Linus Walleij , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Geert Uytterhoeven , Kent Gibson , Jonathan Corbet , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , linux-doc , Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Mar 4, 2021 at 1:59 PM Andy Shevchenko wrote: > > On Thu, Mar 04, 2021 at 11:24:45AM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > The 'extern' keyword doesn't have any benefits in header files. Remove it. > > Reviewed-by: Andy Shevchenko > A few nitpicks below. > > > Signed-off-by: Bartosz Golaszewski > > --- Hi Andy, regarding this patch and other places where you raise issues with line breaking: I believe this is purely a question of taste. There are no guidelines on line breaking in the docs. I will leave it as it is here because it's not better or worse than your version, just different. Same for exceeding 80 characters - I personally believe it's justified when the line looks better but whenever it can be cleanly broken, it's better to stay within the limit. Best Regards, Bartosz