From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Kent Gibson <warthog618@gmail.com>
Cc: linux-gpio@vger.kernel.org
Subject: Re: [libgpiod][PATCH 2/8] tools: tests: don't declare and assign separately
Date: Mon, 3 Jun 2024 12:38:09 +0200 [thread overview]
Message-ID: <CAMRc=MdKTXeLWMkaRqg6z-iTeThWWCYcr4En2UgbM-81BXPFpg@mail.gmail.com> (raw)
In-Reply-To: <20240603085844.GA78808@rigel>
On Mon, Jun 3, 2024 at 10:58 AM Kent Gibson <warthog618@gmail.com> wrote:
>
> On Mon, Jun 03, 2024 at 10:52:39AM +0200, Bartosz Golaszewski wrote:
> > On Fri, May 31, 2024 at 3:45 PM Kent Gibson <warthog618@gmail.com> wrote:
> > >
> > > Fix shellcheck SC2155[1] - declare and assign separately to avoid
> > > masking return values.
> > >
> > > Signed-off-by: Kent Gibson <warthog618@gmail.com>
> > >
> > > [1] https://www.shellcheck.net/wiki/SC2155
> > > ---
> >
> > Shouldn't the commit message say "*do* declare and assign separately"?
> >
>
> That is wrong, my bad.
>
> I think I was going to change it to "don't declare and assign together"
> and got distracted mid-edit.
> So either that or simply "declare and assign separately".
> A leading "do" would be redundant.
>
> You ok to fix that, or would you like a re-spin?
>
I'll fix it, others look good.
Bart
next prev parent reply other threads:[~2024-06-03 10:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 13:45 [libgpiod][PATCH 0/8] tools: tests: fix shellcheck warnings Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 1/8] tools: tests: don't mix string and array Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 2/8] tools: tests: don't declare and assign separately Kent Gibson
2024-06-03 8:52 ` Bartosz Golaszewski
2024-06-03 8:58 ` Kent Gibson
2024-06-03 10:38 ` Bartosz Golaszewski [this message]
2024-06-03 10:39 ` Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 3/8] tools: tests: fix unused variables Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 4/8] tools: tests: use read -r to avoid mangling backslashes Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 5/8] tools: tests: don't use variables in printf format string Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 6/8] tools: tests: check exit code directly Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 7/8] tools: tests: shellcheck don't follow sourced file Kent Gibson
2024-05-31 13:45 ` [libgpiod][PATCH 8/8] tools: tests: avoid splitting and globbing Kent Gibson
2024-06-03 10:40 ` [libgpiod][PATCH 0/8] tools: tests: fix shellcheck warnings Bartosz Golaszewski
2024-06-03 10:43 ` Kent Gibson
2024-06-03 10:59 ` Kent Gibson
2024-06-03 11:51 ` Bartosz Golaszewski
2024-06-03 14:59 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MdKTXeLWMkaRqg6z-iTeThWWCYcr4En2UgbM-81BXPFpg@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).