* [PATCH v2] gpio: mockup: remove gpio debugfs when remove device
@ 2022-08-22 4:10 Wei Yongjun
2022-08-28 13:59 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2022-08-22 4:10 UTC (permalink / raw)
To: Bamvor Jian Zhang, Linus Walleij, Bartosz Golaszewski
Cc: Wei Yongjun, linux-gpio, linux-kernel
GPIO mockup debugfs is created in gpio_mockup_probe() but
forgot to remove when remove device. This patch add a devm
managed callback for removing them.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: return from devm_add_xx directly as Bartosz's suggestion
---
drivers/gpio/gpio-mockup.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index 8943cea92764..a2e505a7545c 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -373,6 +373,13 @@ static void gpio_mockup_debugfs_setup(struct device *dev,
}
}
+static void gpio_mockup_debugfs_cleanup(void *data)
+{
+ struct gpio_mockup_chip *chip = data;
+
+ debugfs_remove_recursive(chip->dbg_dir);
+}
+
static void gpio_mockup_dispose_mappings(void *data)
{
struct gpio_mockup_chip *chip = data;
@@ -455,7 +462,7 @@ static int gpio_mockup_probe(struct platform_device *pdev)
gpio_mockup_debugfs_setup(dev, chip);
- return 0;
+ return devm_add_action_or_reset(dev, gpio_mockup_debugfs_cleanup, chip);
}
static const struct of_device_id gpio_mockup_of_match[] = {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] gpio: mockup: remove gpio debugfs when remove device
2022-08-22 4:10 [PATCH v2] gpio: mockup: remove gpio debugfs when remove device Wei Yongjun
@ 2022-08-28 13:59 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2022-08-28 13:59 UTC (permalink / raw)
To: Wei Yongjun
Cc: Bamvor Jian Zhang, Linus Walleij, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List
On Mon, Aug 22, 2022 at 5:52 AM Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> GPIO mockup debugfs is created in gpio_mockup_probe() but
> forgot to remove when remove device. This patch add a devm
> managed callback for removing them.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> v1 -> v2: return from devm_add_xx directly as Bartosz's suggestion
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-28 13:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-22 4:10 [PATCH v2] gpio: mockup: remove gpio debugfs when remove device Wei Yongjun
2022-08-28 13:59 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).