From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/1] gpiolib: Remove duplicative check in gpiod_find_and_request()
Date: Wed, 15 Mar 2023 10:48:16 +0100 [thread overview]
Message-ID: <CAMRc=Mdsnvrh1NtKoSHwG-5NETGqjiZytPOJ-45YJvya1k0Ngg@mail.gmail.com> (raw)
In-Reply-To: <20230309185626.84997-1-andriy.shevchenko@linux.intel.com>
On Thu, Mar 9, 2023 at 7:56 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The gpiod_find_by_fwnode() already checks for NULL and returns
> correct error code in case fwnode is invalid. Drop the respective
> check and assignment in the gpiod_find_and_request().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/gpio/gpiolib.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 8ecfe3afde1e..333ccd44e2b2 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -3927,13 +3927,10 @@ static struct gpio_desc *gpiod_find_and_request(struct device *consumer,
> bool platform_lookup_allowed)
> {
> unsigned long lookupflags = GPIO_LOOKUP_FLAGS_DEFAULT;
> - struct gpio_desc *desc = ERR_PTR(-ENOENT);
> + struct gpio_desc *desc;
> int ret;
>
> - if (!IS_ERR_OR_NULL(fwnode))
> - desc = gpiod_find_by_fwnode(fwnode, consumer, con_id, idx,
> - &flags, &lookupflags);
> -
> + desc = gpiod_find_by_fwnode(fwnode, consumer, con_id, idx, &flags, &lookupflags);
> if (gpiod_not_found(desc) && platform_lookup_allowed) {
> /*
> * Either we are not using DT or ACPI, or their lookup did not
> --
> 2.39.1
>
Applied, thanks!
Bart
prev parent reply other threads:[~2023-03-15 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 18:56 [PATCH v1 1/1] gpiolib: Remove duplicative check in gpiod_find_and_request() Andy Shevchenko
2023-03-10 9:42 ` Linus Walleij
2023-03-15 9:48 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=Mdsnvrh1NtKoSHwG-5NETGqjiZytPOJ-45YJvya1k0Ngg@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).