From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01D30C61DA4 for ; Wed, 15 Mar 2023 09:49:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231455AbjCOJtZ (ORCPT ); Wed, 15 Mar 2023 05:49:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232105AbjCOJsj (ORCPT ); Wed, 15 Mar 2023 05:48:39 -0400 Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [IPv6:2607:f8b0:4864:20::e31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 877315BD91 for ; Wed, 15 Mar 2023 02:48:27 -0700 (PDT) Received: by mail-vs1-xe31.google.com with SMTP id x25so8352084vsj.2 for ; Wed, 15 Mar 2023 02:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; t=1678873706; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i9wrGaACCmAawpvI5IWRWR5riYVn9bE721EgbamNCo8=; b=M3I5pqT0ftPGbU3JaYLh3CiD3Ge+e+0lK8AcQCt7aB7PF8QByEm6O/bbsd7ZvCk1yd odUDFSa9CLgnP6U9nZnpsD9vN70O8UXTK16HB64m7k528iHbd33Gu3HzLARTz1wHwDvV ZM8XD2odSOLMq1n5xx0vdB3sb4tv7RmpkRI65qO4mYibDZdraZkcE977MdHxYecZHpUw fJhgyOFNy1+TF/1tjvmkHsVlDYLFT6fQubCmefWUKlm+MvZFy2VMeK/jLUfzGRIDFdX7 KWqhtI5eYAzLBJTsFWmJnTbUmRkYWwcfPF0A0seS+qxxCG9jQlfPE+vR09SjRSURvtIV Z2PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678873706; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i9wrGaACCmAawpvI5IWRWR5riYVn9bE721EgbamNCo8=; b=TWn5WQJnWBlS5Gxd8yIOcHU9U3O3x5xwF4Y45B+ajjp7dTdvLMcvmP1InbtiCwg8UD V4cF9jOG4p/ThxbJBmQhWMNRPseIwF8FwZw7Uioq/QAYutatP8gdvy53JPlHJY5HS+jZ goVbqBvPwdiar8Wkmyt+sv/CLUSQ0dAUuwKFfN1U0zGUS2oXittWXCNTwnmUVN3asD35 hK+tVn7K30RyMfzjBGF2ntlh0pUQbAlLx7aUCarMMPfemQH/KS6uNNWJJR7QtlNvrK4t 1YjMW9dEX/MOdZtdcAdxk6e00MXhXWzanpnAjS7GwgZonbX95NUxen/BxqqAB/JgLfnm oQzw== X-Gm-Message-State: AO0yUKWy5HwwRofIVqMAUp0YQf3vIRV45BvCKQhE+gmiUhWDaKrANAJu fNfONyGl9W6r5fVUxuAfyGYyar6JMCPFhFnix7pT2g== X-Google-Smtp-Source: AK7set9AFjmytAOZT2FHo+ktlYDH9ACmI1Dub/5Du0LrMXs2zgBbrQAxme3xfQUJ2jg0BJ7+0oGr3YhpKWzuXaFHdkI= X-Received: by 2002:a67:ee48:0:b0:425:a141:2af5 with SMTP id g8-20020a67ee48000000b00425a1412af5mr4480269vsp.2.1678873706649; Wed, 15 Mar 2023 02:48:26 -0700 (PDT) MIME-Version: 1.0 References: <20230309185626.84997-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20230309185626.84997-1-andriy.shevchenko@linux.intel.com> From: Bartosz Golaszewski Date: Wed, 15 Mar 2023 10:48:16 +0100 Message-ID: Subject: Re: [PATCH v1 1/1] gpiolib: Remove duplicative check in gpiod_find_and_request() To: Andy Shevchenko Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Mar 9, 2023 at 7:56=E2=80=AFPM Andy Shevchenko wrote: > > The gpiod_find_by_fwnode() already checks for NULL and returns > correct error code in case fwnode is invalid. Drop the respective > check and assignment in the gpiod_find_and_request(). > > Signed-off-by: Andy Shevchenko > --- > drivers/gpio/gpiolib.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 8ecfe3afde1e..333ccd44e2b2 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -3927,13 +3927,10 @@ static struct gpio_desc *gpiod_find_and_request(s= truct device *consumer, > bool platform_lookup_allo= wed) > { > unsigned long lookupflags =3D GPIO_LOOKUP_FLAGS_DEFAULT; > - struct gpio_desc *desc =3D ERR_PTR(-ENOENT); > + struct gpio_desc *desc; > int ret; > > - if (!IS_ERR_OR_NULL(fwnode)) > - desc =3D gpiod_find_by_fwnode(fwnode, consumer, con_id, i= dx, > - &flags, &lookupflags); > - > + desc =3D gpiod_find_by_fwnode(fwnode, consumer, con_id, idx, &fla= gs, &lookupflags); > if (gpiod_not_found(desc) && platform_lookup_allowed) { > /* > * Either we are not using DT or ACPI, or their lookup di= d not > -- > 2.39.1 > Applied, thanks! Bart