From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Erik Schilling <erik.schilling@linaro.org>
Cc: Kent Gibson <warthog618@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Linux-GPIO <linux-gpio@vger.kernel.org>,
Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Subject: Re: [libgpiod][PATCH v4] bindings: rust: rename {event,settings}_clone to try_clone
Date: Wed, 4 Oct 2023 16:41:52 +0200 [thread overview]
Message-ID: <CAMRc=MeBiuccxDVLzB6idwby3B9y-rSBk5ENt+KRkvQ16UV8bg@mail.gmail.com> (raw)
In-Reply-To: <20231004-rust-line-info-soundness-v4-1-cff89db04aa5@linaro.org>
On Wed, Oct 4, 2023 at 3:00 PM Erik Schilling <erik.schilling@linaro.org> wrote:
>
> What is getting cloned is already clear from the type. This also aligns
> a bit better with similar methods from the `std` crate [1].
>
> [1] https://doc.rust-lang.org/std/index.html?search=try_clone
>
> Link: https://lore.kernel.org/r/CVUKC1HXG1P8.13XIUCCXN95F0@ablu-work
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Erik Schilling <erik.schilling@linaro.org>
> ---
> Resending only the missing patch, rebased on the others.
Thanks, now applied.
Bart
prev parent reply other threads:[~2023-10-04 14:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 13:00 [libgpiod][PATCH v4] bindings: rust: rename {event,settings}_clone to try_clone Erik Schilling
2023-10-04 14:41 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MeBiuccxDVLzB6idwby3B9y-rSBk5ENt+KRkvQ16UV8bg@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=erik.schilling@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=manos.pitsidianakis@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).