* [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base
@ 2022-11-12 15:29 Aidan MacDonald
2022-11-14 10:03 ` Linus Walleij
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Aidan MacDonald @ 2022-11-12 15:29 UTC (permalink / raw)
To: michael, linus.walleij, brgl; +Cc: linux-gpio, linux-kernel
Remove use of the deprecated mask_invert flag. Inverted mask
registers (where a '1' bit enables an IRQ) can be described more
directly as an unmask register.
Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
---
drivers/gpio/gpio-sl28cpld.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-sl28cpld.c b/drivers/gpio/gpio-sl28cpld.c
index 52404736ac86..2195f88c2048 100644
--- a/drivers/gpio/gpio-sl28cpld.c
+++ b/drivers/gpio/gpio-sl28cpld.c
@@ -70,8 +70,7 @@ static int sl28cpld_gpio_irq_init(struct platform_device *pdev,
irq_chip->num_irqs = ARRAY_SIZE(sl28cpld_gpio_irqs);
irq_chip->num_regs = 1;
irq_chip->status_base = base + GPIO_REG_IP;
- irq_chip->mask_base = base + GPIO_REG_IE;
- irq_chip->mask_invert = true;
+ irq_chip->unmask_base = base + GPIO_REG_IE;
irq_chip->ack_base = base + GPIO_REG_IP;
ret = devm_regmap_add_irq_chip_fwnode(dev, dev_fwnode(dev),
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base
2022-11-12 15:29 [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base Aidan MacDonald
@ 2022-11-14 10:03 ` Linus Walleij
2022-11-15 14:42 ` Bartosz Golaszewski
2022-11-16 6:59 ` Michael Walle
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2022-11-14 10:03 UTC (permalink / raw)
To: Aidan MacDonald; +Cc: michael, brgl, linux-gpio, linux-kernel, Marc Zyngier
On Sat, Nov 12, 2022 at 4:29 PM Aidan MacDonald
<aidanmacdonald.0x0@gmail.com> wrote:
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Makes sense
Acked-by: Linus Walleij <linus.walleij@linaro.org>
I expected to see Maz on CC for this kind of patches so added him.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base
2022-11-12 15:29 [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base Aidan MacDonald
2022-11-14 10:03 ` Linus Walleij
@ 2022-11-15 14:42 ` Bartosz Golaszewski
2022-11-16 6:59 ` Michael Walle
2 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2022-11-15 14:42 UTC (permalink / raw)
To: Aidan MacDonald; +Cc: michael, linus.walleij, linux-gpio, linux-kernel
On Sat, Nov 12, 2022 at 4:29 PM Aidan MacDonald
<aidanmacdonald.0x0@gmail.com> wrote:
>
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> ---
> drivers/gpio/gpio-sl28cpld.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sl28cpld.c b/drivers/gpio/gpio-sl28cpld.c
> index 52404736ac86..2195f88c2048 100644
> --- a/drivers/gpio/gpio-sl28cpld.c
> +++ b/drivers/gpio/gpio-sl28cpld.c
> @@ -70,8 +70,7 @@ static int sl28cpld_gpio_irq_init(struct platform_device *pdev,
> irq_chip->num_irqs = ARRAY_SIZE(sl28cpld_gpio_irqs);
> irq_chip->num_regs = 1;
> irq_chip->status_base = base + GPIO_REG_IP;
> - irq_chip->mask_base = base + GPIO_REG_IE;
> - irq_chip->mask_invert = true;
> + irq_chip->unmask_base = base + GPIO_REG_IE;
> irq_chip->ack_base = base + GPIO_REG_IP;
>
> ret = devm_regmap_add_irq_chip_fwnode(dev, dev_fwnode(dev),
> --
> 2.38.1
>
Applied, thanks!
Bartosz
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base
2022-11-12 15:29 [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base Aidan MacDonald
2022-11-14 10:03 ` Linus Walleij
2022-11-15 14:42 ` Bartosz Golaszewski
@ 2022-11-16 6:59 ` Michael Walle
2 siblings, 0 replies; 4+ messages in thread
From: Michael Walle @ 2022-11-16 6:59 UTC (permalink / raw)
To: Aidan MacDonald; +Cc: linus.walleij, brgl, linux-gpio, linux-kernel
Am 2022-11-12 16:29, schrieb Aidan MacDonald:
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Sorry for the late response, I was on vacation.
I see that it was already applied, so just for the record:
Acked-by: Michael Walle <michael@walle.cc>
Thanks for taking care,
-michael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-16 6:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-12 15:29 [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base Aidan MacDonald
2022-11-14 10:03 ` Linus Walleij
2022-11-15 14:42 ` Bartosz Golaszewski
2022-11-16 6:59 ` Michael Walle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).