From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F41DC433FE for ; Tue, 15 Nov 2022 14:44:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238328AbiKOOoT (ORCPT ); Tue, 15 Nov 2022 09:44:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238506AbiKOOnz (ORCPT ); Tue, 15 Nov 2022 09:43:55 -0500 Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F28332EF54 for ; Tue, 15 Nov 2022 06:42:21 -0800 (PST) Received: by mail-vs1-xe34.google.com with SMTP id z189so14844416vsb.4 for ; Tue, 15 Nov 2022 06:42:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=84ckuklXks9HDjrkjMUEdy8dxhQSVXrlasgbqbXw1SM=; b=hgUxmimdIPmB+4nNGYIJ9EdfOw9q+yFbT/NQFg3dHBOhblRrcqIQqhEEe/Z+nc60z2 +38wv6QLa5IcwpbYhGSbbiwsA4nVplmuGpZ8mG55oBC5VyZnOlPtpXS/+YIQCyqgU53c udt6lVY4pPw3DWWmKOkiSUWUK2DJSNq4DQahxBuv5kYNb6B72sQvbccO2RY7GIROgvZI 3/UzWGJS6u4LfbTM8gjZYEbUIozPsPm5ucgAPfTovxj1Ru3phDypn15hV/g6w4KatfwU MP+nXZQF8qAW8ovZmJ8Tx7Ry/e1DkHJ76bwr8ss8SUOCO6zFUrCmRVqwPbITO68g+dnG 6lVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=84ckuklXks9HDjrkjMUEdy8dxhQSVXrlasgbqbXw1SM=; b=zU5pMm11vuAvPz3oRZO9jnnOmevu2AQuy9DfEzFkpexKaUw0OFMCHmud0CEUAKS7dC 9AMRUkzV5Nc2GHIyB8OyXuZzbMsaMB0hSoXrnAo9zZksMfpwym3VAqkELlTfVQV/7hWb H2Ul6FGhmymaKGCo2wtoO3Hkd3iA8WM4tqsnPOLehn64W/DHHQo5MexuTVpMRcvALVqq p93+3ghSBoyY1pD5i/NSztMcpg6gaWV4X8tqKJoQB7xQ5NPdAUtBuhlRFkA2GgCuKjOr nhBzIqtuvzJ34t1aftpv29gCxbvkfWjdG+yp9JY5pgh24LaTsGHnfV506r6/yKmtU1A4 cc3g== X-Gm-Message-State: ANoB5pnOqLGWY91TfMeWtfp/Lg1gTh1cP05kxNGiiQjFrdWD+RHf7Ghl uo4DtmfakLu2AeR66oJmllU/4RIMjrV97yMTqKVlPQ== X-Google-Smtp-Source: AA0mqf5RcHXLxh4wClwTJ+sdCRhxHg6wKKdKXlFyBmeMuQBZMb6iWnNvGMAHZvmHMvjFHk9vIJ7Vs0S9Whvpr/9nPxg= X-Received: by 2002:a05:6102:4187:b0:3aa:c58:66 with SMTP id cd7-20020a056102418700b003aa0c580066mr8989589vsb.47.1668523340865; Tue, 15 Nov 2022 06:42:20 -0800 (PST) MIME-Version: 1.0 References: <20221112152928.42204-1-aidanmacdonald.0x0@gmail.com> In-Reply-To: <20221112152928.42204-1-aidanmacdonald.0x0@gmail.com> From: Bartosz Golaszewski Date: Tue, 15 Nov 2022 15:42:09 +0100 Message-ID: Subject: Re: [PATCH] gpio: sl28cpld: Replace irqchip mask_invert with unmask_base To: Aidan MacDonald Cc: michael@walle.cc, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, Nov 12, 2022 at 4:29 PM Aidan MacDonald wrote: > > Remove use of the deprecated mask_invert flag. Inverted mask > registers (where a '1' bit enables an IRQ) can be described more > directly as an unmask register. > > Signed-off-by: Aidan MacDonald > --- > drivers/gpio/gpio-sl28cpld.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-sl28cpld.c b/drivers/gpio/gpio-sl28cpld.c > index 52404736ac86..2195f88c2048 100644 > --- a/drivers/gpio/gpio-sl28cpld.c > +++ b/drivers/gpio/gpio-sl28cpld.c > @@ -70,8 +70,7 @@ static int sl28cpld_gpio_irq_init(struct platform_device *pdev, > irq_chip->num_irqs = ARRAY_SIZE(sl28cpld_gpio_irqs); > irq_chip->num_regs = 1; > irq_chip->status_base = base + GPIO_REG_IP; > - irq_chip->mask_base = base + GPIO_REG_IE; > - irq_chip->mask_invert = true; > + irq_chip->unmask_base = base + GPIO_REG_IE; > irq_chip->ack_base = base + GPIO_REG_IP; > > ret = devm_regmap_add_irq_chip_fwnode(dev, dev_fwnode(dev), > -- > 2.38.1 > Applied, thanks! Bartosz