From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Vincent Fazio <vfazio@gmail.com>
Cc: linux-gpio@vger.kernel.org, Vincent Fazio <vfazio@xes-inc.com>
Subject: Re: [libgpiod][PATCH] bindings: python: tests: skip some reconfigure tests on older kernels
Date: Fri, 27 Sep 2024 10:03:45 +0200 [thread overview]
Message-ID: <CAMRc=MefY_J3n=wFJDwzL+4s8f52ECGxNB5UWGcnD-ncD2cnQg@mail.gmail.com> (raw)
In-Reply-To: <20240923182550.3724996-1-vfazio@xes-inc.com>
On Mon, Sep 23, 2024 at 8:27 PM Vincent Fazio <vfazio@gmail.com> wrote:
>
> Commit 40db20e added tests to ensure that lines that were either missing
> from a reconfigure call or were included but had no LineSettings defined
> would _not_ change configuration.
>
> However, this functionality requires the changes from kernel commit
> b44039638 to work as expected. This commit exists in the 6.10 kernel and
> was backported to 6.9.8 [0].
>
> Now, these tests are skipped if the kernel version is older than 6.9.8.
>
> [0]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=d972e7b24a50d1f89967d5bffc3147810af9222d
> Fixes: 40db20eec045 ("bindings: python: tests: extend reconfiguration tests")
> Signed-off-by: Vincent Fazio <vfazio@xes-inc.com>
> ---
As discussed on github: I prefer the older stable kernel branches to
have the relevant patch from Kent backported than to start adding this
kind of unmaintainable ifdiffery to tests. I see Greg already started
picking up the backports so let's drop this for now.
Bart
prev parent reply other threads:[~2024-09-27 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 18:25 [libgpiod][PATCH] bindings: python: tests: skip some reconfigure tests on older kernels Vincent Fazio
2024-09-27 8:03 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MefY_J3n=wFJDwzL+4s8f52ECGxNB5UWGcnD-ncD2cnQg@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
--cc=vfazio@gmail.com \
--cc=vfazio@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).