From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC56C54EBE for ; Mon, 16 Jan 2023 09:06:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232560AbjAPJGY (ORCPT ); Mon, 16 Jan 2023 04:06:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232519AbjAPJF7 (ORCPT ); Mon, 16 Jan 2023 04:05:59 -0500 Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F411C18A9C for ; Mon, 16 Jan 2023 01:03:30 -0800 (PST) Received: by mail-vs1-xe32.google.com with SMTP id l125so9028995vsc.2 for ; Mon, 16 Jan 2023 01:03:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=32WOcoXO5ldk2Em3aPyakA0jH+HICU+rv07Xae29T34=; b=UeKy7hV7fsyqRTX4F+f8YoVuVc8GCJKGrtdglTgVFNwp+8Zfjxmx1qn3D0BBla46ob Gh3br7pcEbiK1SlN//rVokX6zM2cA/VAEj0XOFOfvC2gOTriSeGdFeCuKHGoQfBTHQUV LCIHNsO7dnZ2++tNwHecVk7Qnn7K8MncHEfd4Lq2xh0mltR/jWtZeFT8uymZgge1o8h8 nibai1IafatnXYQGi4kjpLB8bTdZLRCg+g/+7ZggDFjX4zQZu80Z7XBtI4UWbJwZol1M Dv5Xa4WswNdVNOsQqKuuk8qX6oje+dqCK8hg9Y8f7a4XQyo2WFYGWtINHH82S/zUDY2D nCeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=32WOcoXO5ldk2Em3aPyakA0jH+HICU+rv07Xae29T34=; b=d/FjMYGnQ+5yS7tM0sAPZsO4jjU84IgOYblJjJm1klQ5Q5wlrQBE1FrsfkPVdyrkjP AvJUavEgQSQK2OEsYzISpZG21Rx0wE/50C15UdHIsOyCCY/q4/MeQbB1FIBW9bUViubq OAAkq9w48zPFD2Y0vbeGT9q/fKZBRzPnwCX9HpFJPdJLk9g0cX8Qz9Nu8aUB/JAmhASp C5lWR3rUUvX53UWusgj9QfxU8n4M/6ZhJ3T0s+DBL0Sp0uGy1jTrryUH02j+LTTZgY+E tQQ7NKAhjTemgDrqxxmwO7RDGGExO8Lhtb4DxS3LpegXKm0eEywNPR7JCho8fjR+Jdb6 8d4Q== X-Gm-Message-State: AFqh2korAUnoTvMvXc239OcsXy2vVlkiog4E7MdDhAcXd5qnmGGjIZcr tLpnc7Y6WW61MrdKlk3V4wrwS02FubuMHSXYeOHneg== X-Google-Smtp-Source: AMrXdXthmHPScO+QHMGTj79l65q9+ThrjSLYcDLQJ5STDs5sRva9j0NY+z+2mTr+aBOVsQ37f5IX8ldpO4CCkLZWUDE= X-Received: by 2002:a05:6102:83b:b0:3d1:3753:9a3c with SMTP id k27-20020a056102083b00b003d137539a3cmr1433742vsb.73.1673859810089; Mon, 16 Jan 2023 01:03:30 -0800 (PST) MIME-Version: 1.0 References: <20230113182619.16800-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20230113182619.16800-1-andriy.shevchenko@linux.intel.com> From: Bartosz Golaszewski Date: Mon, 16 Jan 2023 10:03:19 +0100 Message-ID: Subject: Re: [PATCH v2 1/2] gpio: wcd934x: Remove duplicate assignment of of_gpio_n_cells To: Andy Shevchenko Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Jan 13, 2023 at 7:25 PM Andy Shevchenko wrote: > > The of_gpio_n_cells default is 2 when ->of_xlate() callback is > not defined. No need to assign it explicitly in the driver. > > Signed-off-by: Andy Shevchenko > --- > v2: no changes > drivers/gpio/gpio-wcd934x.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpio/gpio-wcd934x.c b/drivers/gpio/gpio-wcd934x.c > index 97e6caedf1f3..817750e4e033 100644 > --- a/drivers/gpio/gpio-wcd934x.c > +++ b/drivers/gpio/gpio-wcd934x.c > @@ -98,7 +98,6 @@ static int wcd_gpio_probe(struct platform_device *pdev) > chip->base = -1; > chip->ngpio = WCD934X_NPINS; > chip->label = dev_name(dev); > - chip->of_gpio_n_cells = 2; > chip->can_sleep = false; > > return devm_gpiochip_add_data(dev, chip, data); > -- > 2.39.0 > Applied, thanks! Bart