From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Kent Gibson" <warthog618@gmail.com>, "Jan Lübbe" <jlu@pengutronix.de>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
Marek Vasut <marex@denx.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v3 00/10] gpio: sysfs: add a per-chip export/unexport attribute pair
Date: Wed, 2 Jul 2025 12:28:01 +0200 [thread overview]
Message-ID: <CAMRc=MeuMpo0=ym+FvDh5sCNXM00+iOSNFgTxMqagO78ZS64_g@mail.gmail.com> (raw)
In-Reply-To: <20250702101212.GA47772@rigel>
On Wed, Jul 2, 2025 at 12:12 PM Kent Gibson <warthog618@gmail.com> wrote:
>
> >
> > I tend to not interpret it as adding new features. We really just
> > *move* what exists under a slightly different path when you think
> > about it.
> >
> > So what are you suggesting, remove the `edge` attribute and polling
> > features from the new `value` attribute?
> >
>
> Exactly. I'm not suggesting ANY changes to the old sysfs, only your new
> non-global numbering version. The idea being don't port everything over
> from the old sysfs - just the core feature set that non-cdev users need.
>
I mean, if someone shows up saying they need this or that from the old
sysfs and without they won't switch, we can always add it back I
guess... Much easier than removing something that's carved in stone.
Anything else should go away? `active_low`?
Bart
next prev parent reply other threads:[~2025-07-02 10:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 12:37 [PATCH v3 00/10] gpio: sysfs: add a per-chip export/unexport attribute pair Bartosz Golaszewski
2025-06-30 12:37 ` [PATCH v3 01/10] gpio: sysfs: use gpiod_is_equal() to compare GPIO descriptors Bartosz Golaszewski
2025-07-04 8:05 ` Linus Walleij
2025-06-30 12:37 ` [PATCH v3 02/10] gpio: sysfs: add a parallel class device for each GPIO chip using device IDs Bartosz Golaszewski
2025-06-30 12:37 ` [PATCH v3 03/10] gpio: sysfs: only get the dirent reference for the value attr once Bartosz Golaszewski
2025-07-04 8:05 ` Linus Walleij
2025-06-30 12:37 ` [PATCH v3 04/10] gpio: sysfs: pass gpiod_data directly to internal GPIO sysfs functions Bartosz Golaszewski
2025-06-30 12:37 ` [PATCH v3 05/10] gpio: sysfs: rename the data variable in gpiod_(un)export() Bartosz Golaszewski
2025-06-30 12:37 ` [PATCH v3 06/10] gpio: sysfs: don't use driver data in sysfs callbacks for line attributes Bartosz Golaszewski
2025-06-30 13:27 ` Andy Shevchenko
2025-06-30 13:39 ` Bartosz Golaszewski
2025-06-30 14:22 ` Andy Shevchenko
2025-06-30 12:37 ` [PATCH v3 07/10] gpio: sysfs: don't look up exported lines as class devices Bartosz Golaszewski
2025-06-30 12:37 ` [PATCH v3 08/10] gpio: sysfs: export the GPIO directory locally in the gpiochip<id> directory Bartosz Golaszewski
2025-07-04 8:06 ` Linus Walleij
2025-06-30 12:37 ` [PATCH v3 09/10] gpio: sysfs: allow disabling the legacy parts of the GPIO sysfs interface Bartosz Golaszewski
2025-06-30 12:37 ` [PATCH v3 10/10] gpio: TODO: remove the task for the sysfs rework Bartosz Golaszewski
2025-07-04 8:09 ` Linus Walleij
2025-07-01 14:05 ` [PATCH v3 00/10] gpio: sysfs: add a per-chip export/unexport attribute pair Andy Shevchenko
2025-07-02 3:54 ` Kent Gibson
2025-07-02 9:45 ` Bartosz Golaszewski
2025-07-02 10:12 ` Kent Gibson
2025-07-02 10:28 ` Bartosz Golaszewski [this message]
2025-07-02 11:01 ` Kent Gibson
2025-07-02 11:59 ` Andy Shevchenko
2025-07-02 12:42 ` Kent Gibson
2025-07-02 12:05 ` Geert Uytterhoeven
2025-07-02 11:55 ` Andy Shevchenko
2025-07-02 13:18 ` Bartosz Golaszewski
2025-07-04 8:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MeuMpo0=ym+FvDh5sCNXM00+iOSNFgTxMqagO78ZS64_g@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=a.fatoum@pengutronix.de \
--cc=andriy.shevchenko@intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=geert+renesas@glider.be \
--cc=jlu@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).