From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F195EE4993 for ; Mon, 21 Aug 2023 12:18:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234636AbjHUMSC (ORCPT ); Mon, 21 Aug 2023 08:18:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231500AbjHUMSC (ORCPT ); Mon, 21 Aug 2023 08:18:02 -0400 Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE747CC for ; Mon, 21 Aug 2023 05:18:00 -0700 (PDT) Received: by mail-ua1-x932.google.com with SMTP id a1e0cc1a2514c-7a02252eb5dso597669241.1 for ; Mon, 21 Aug 2023 05:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20221208.gappssmtp.com; s=20221208; t=1692620280; x=1693225080; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XKkqJ2D+VYmFpqgXIvrMOHKS8idoVbV815zLuujvJZs=; b=YIqtFhVFWX+SbtXg0CB8V/ecOt3HTYUkL+zNlaUq4xauI4O5ombFF+UXPYh1xKAnwv hX5Hoi0c7nRk2vchMn9FY12TS4FQWDLbTOGSYhSfIBWOia/7C0vefYOp0MeOsvTC1FBE twXBWQMqAcVXPO/vH8p9AgDVV/1dx4BL76Hw1C3C5ahwMFrOvvDIpYT0C3azLL6cV2cD /ImBXm/iM7QOFvAFhzZSAozkd+FRNa4nTPSsYpFJGlaxkW2mQGe5k/e0NQuQt6yfwj7J s0Bp+q1gGnKh1Awvf3dogVd8jWadEjDAEbMN+iVH1mHcglBjv0kMnF/gE06YNcNLoJZR RfYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692620280; x=1693225080; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XKkqJ2D+VYmFpqgXIvrMOHKS8idoVbV815zLuujvJZs=; b=UJozb38VoFWtXpx3zWfSk1GHoCN7nKhDBuICzYFM2F+jdaD0zh1P84vosamjlMG/13 JhIIdJYHhZqxECU3JQ7ZtOeqPwjYEFJh7ceC+4fMlAwB+BCk7qTlLf6hmieJe15lJudx jBagpyZcMxJij5Sp8Syg7lNhjuaScohXyj3XwnKU6NRAx19neRh5DVd1cAdbyTAeOpu/ BhicVK3IVYxhUeBkeQAAg8J3fDDXv5PJW8RvqoUoBhn7n9REkEkxyUkUTaoiqvgY0XL8 pgpvdbkYPIfiFthulcDDq0yxjFdwT5887bEEuLY0bc+DtP964cRsVb6Ii87yp1qjEk65 xX8A== X-Gm-Message-State: AOJu0Ywqm64pb4bbuiim7Y+9wWNe1ktXB7KWM+5Sc7G+1G/FgNTQ6yXE SXgReAO5ZsTKLixonp8uFUUmdl/PQuRfX2GtBkBvjw== X-Google-Smtp-Source: AGHT+IGcqJGwYRyNganLabVsKBovtI5E+Kj3jh5UkDOLGsB5Bm8B/LZ1IeAgNEscpo/ZIn2ODYoBy019wgMqpbrTk08= X-Received: by 2002:a67:eb06:0:b0:44d:5298:5bfc with SMTP id a6-20020a67eb06000000b0044d52985bfcmr902841vso.17.1692620279900; Mon, 21 Aug 2023 05:17:59 -0700 (PDT) MIME-Version: 1.0 References: <20230506085928.933737-1-haibo.chen@nxp.com> <12270129.O9o76ZdvQC@steina-w> In-Reply-To: From: Bartosz Golaszewski Date: Mon, 21 Aug 2023 14:17:48 +0200 Message-ID: Subject: Re: [PATCH 2/2] gpio: mxc: switch to dynamic allocat GPIO base To: Linus Walleij Cc: Alexander Stein , Bough Chen , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "christophe.leroy@csgroup.eu" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Aug 21, 2023 at 12:21=E2=80=AFPM Linus Walleij wrote: > > On Mon, Aug 21, 2023 at 9:44=E2=80=AFAM Alexander Stein > wrote: > > Am Montag, 21. August 2023, 09:25:54 CEST schrieb Linus Walleij: > > > On Mon, Aug 21, 2023 at 4:47=E2=80=AFAM Bough Chen wrote:> > Hi > > Linus and Bartosz, > > > > > > > > For this patch, still not in the main trunk (Linux 6.5-rc7) and > > > > linux-next(next-20230818). Can you help apply or any comment? > > > > > > As pointed out by Bartosz you cannot just mechanically switch the bas= e > > > to -1. > > > > > > You also need to convince us that this doesn't break any systems, and= if > > > it does, fix them so they don't break before submitting this patch. > > > > I think it's hard to tell if something breaks, this driver is used in a= lot of > > boards. AFAIR some people are relying on the assumption of fixed order.= Using > > dynamic allocation this not ensured. A possible fix is to use aliases [= 1]. > > Hm I might have been to grumpy! > > It looks like any boardfiles using gpio-mxc have been eliminated > so this driver is now only used in device tree-boots? Right? > > Then I feel a lot better about it. > > Acked-by: Linus Walleij > > Yours, > Linus Walleij I will not be queueing it for v6.6 as merge window opens in a week, I want to give it more time in next and see if anyone complains so it'll make it for v6.7. Bart