From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Benjamin Li <benl@squareup.com>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [libgpiod,v4 0/2] tools: fix compile issues when GNU extensions are not present
Date: Sun, 12 Mar 2023 14:39:26 +0100 [thread overview]
Message-ID: <CAMRc=Mfa_iPc9d2o2wJoFSwDXEG1sHS2Ma9F_oW+wtnahUoXuw@mail.gmail.com> (raw)
In-Reply-To: <20230306184545.1316993-1-benl@squareup.com>
On Mon, Mar 6, 2023 at 7:46 PM Benjamin Li <benl@squareup.com> wrote:
>
> v4:
> - Keep semantics consistent with before: help messages should return the full
> name, not the short name. (Bart)
>
> v3:
> - Collapse --version print into a single line. (Andy)
> - Handle program name fully independently rather than rely on any extensions
> at all. (Bart)
> - Move Android.bp into contrib/ folder. (Bart)
> - Add SPDX license tag and clean up Android.bp patch comments in the context
> of it possibly being accepted into the upstream tree.
>
> v2:
> - Add missing Signed-off-by: tags.
>
> v1:
> Fix issue when building against a C library without GNU extensions, such
> as Android's Bionic libc.
>
> A commit with a sample Android.bp file that's working against Android 11 is
> included for informational purposes, which I don't expect Bartosz to pull.
>
> Benjamin Li (2):
> tools: remove dependency on glibc program_invocation_[short_]name
> contrib: add sample Android.bp to build within an Android tree
>
> contrib/Android.bp | 136 +++++++++++++++++++++++++++++++++++++++++++
> tools/gpiodetect.c | 5 +-
> tools/gpioget.c | 5 +-
> tools/gpioinfo.c | 5 +-
> tools/gpiomon.c | 5 +-
> tools/gpionotify.c | 5 +-
> tools/gpioset.c | 5 +-
> tools/tools-common.c | 34 ++++++++---
> tools/tools-common.h | 4 +-
> 9 files changed, 183 insertions(+), 21 deletions(-)
> create mode 100644 contrib/Android.bp
>
> --
> 2.25.1
>
Thanks, I applied both patches. For the second one: I extended it so
that the android build file ends up in release tarballs generated by
'make dist'.
Bartosz
next prev parent reply other threads:[~2023-03-12 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 18:45 [libgpiod,v4 0/2] tools: fix compile issues when GNU extensions are not present Benjamin Li
2023-03-06 18:45 ` [libgpiod,v4 1/2] tools: remove dependency on glibc program_invocation_[short_]name Benjamin Li
2023-03-06 18:45 ` [libgpiod,v4 2/2] contrib: add sample Android.bp to build within an Android tree Benjamin Li
2023-03-12 13:39 ` Bartosz Golaszewski [this message]
2023-03-13 17:38 ` [libgpiod,v4 0/2] tools: fix compile issues when GNU extensions are not present Benjamin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=Mfa_iPc9d2o2wJoFSwDXEG1sHS2Ma9F_oW+wtnahUoXuw@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=benl@squareup.com \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).