From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE73E229B01 for ; Mon, 10 Mar 2025 13:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741612965; cv=none; b=IF4meRrBMuF1paIPImLZU+XEdLVFkUCipikpOxs7Eam9bvQIaCODt9Q5TyZUEfTzODQaF091hcxJ3cDFDB++kMAfvgFaPMmHEJXYpzyrE6XzIyBqKpZjT+u0JX8utQZ5ZXtt/0cIc0kkIHbiU1wwAXzIlPTwoC44ylCoAL25GGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741612965; c=relaxed/simple; bh=DPKb8ThpUtf/tZId/Di1QGFds3FHv0BZjzDL63AUYKA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=u8WhmERjyvnrSBvcj0hMwaAXdAQNo9rCvh1ousrR7spIClKLzvacpqEKDw+s+gO5YTqtWjDyk+C04rVk26vPFqDhnDNrC0KTe5zWmaY/NZthtqdVKNqJG4PjWCw8TwaskTj7iOjdHybSXr1pfjFjN/Nzlc0D9Gnc8nL7Oe0I9R8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Vz+qn6jX; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Vz+qn6jX" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-30bef9b04adso37818621fa.1 for ; Mon, 10 Mar 2025 06:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1741612961; x=1742217761; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BIR94qx8xpSJrcrgyo8EcRbXb4tKFO0K352zXBNzI/Q=; b=Vz+qn6jXUoH0dwlwtlJsM/oxic8bB7UUO0LC2g4VJ1mDUGgmJBCTY1XsZxAWfWkkc7 U8gXFUdVQeEuBr3TdBy1a1jQT8/dK4bDdI+RQ40ZG4xogl/S5s0zTqzVhCUg/+3N/xcL f65qFxW69HUKA19A2YE9B3B+qEZAbwn64BUj54AYkzLIvMLiQZgJkjeEL2r6rP1yIKUo OXNd9yZaod8dwVZlSrliQdIJajhAvdHq26HIn0DY8X0aRt95XG+bfbW9/qytrmUlCeT/ oAwXm+OdVJ6V9sZeWtnyZPWc0gA7xTi+n+LQe4LZfH3q0DCY+kNes/4YZuvv9tgF7SI0 /0hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741612961; x=1742217761; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BIR94qx8xpSJrcrgyo8EcRbXb4tKFO0K352zXBNzI/Q=; b=AAYd6uZDkB5ehhQJLlfMrHdS338axN6NDkUGybQvpAJSY8aGtkkMMe/fCjJ1Ge71Ja 18kFkTmmSlGrph9ctbnvo+99oob1Mtdi81ToO7CcFYHPJ02A+6qV7RbwLYOeoejRYoyC OQ2powIuJzne7tYSvySfXjIJViCL9h26BAkTXHUMCFxkQyBBYGwlr0ZznWtkRAvo+93H b/8PXMN1u8hFyxB5uMTvOSGzoSytQdivmplsrai9nAs2t+rBJROIDmQoz2IX8TPWj4u4 vN7QXA+yIvGz5WSRR60DP8cnXNAfKpLR0LhO5BxPxkH0JEyb6c2hrAxQWshC8c2dM4hC YAkA== X-Forwarded-Encrypted: i=1; AJvYcCUSN5gcJ6thPLD4F9uoWwCoI1/ye6uqigjVHE42hLX32Rw/JQk0QwMShCqw2bfDfRAJCtyiW3hV/haI@vger.kernel.org X-Gm-Message-State: AOJu0Yw9KxBNYlErg5QHkt/ASl4c2x8Dp5GfqvBBVhWR779YY4ZwUbwu X0yq6RNOdC8/NeDAsyW+NdUkqvLD2gr0MqmCEQ1yspn3HtT5GNTQsU+oqOauMa5Ir0w2WvzPeH9 fFWh5hy7OcGtjk7knw3YAlM1tkm7bRYU5T0VLdw== X-Gm-Gg: ASbGncunrG9lmVe5IIhRCJCVXO7LiPmNtefk8QgB5bo2cPu7tyOvRz95kIGJJRkooUD 9vEQ26fKdQmiyrk1RBZLjJZ0QFLlROlxgldRVNp40Q8f9m7usl9dOF/pc+0fgyokzF6nrxW8A8n GgJowuk+0HQKPQb+4e64hqpK2Bds3451/XAycojxauMg5Jzc07rAX50+dnPA== X-Google-Smtp-Source: AGHT+IEt6orrR0LbnqijRHsXsXIoP9u4govV2U4kennnDAB8LKxqgLR624RGe5IQ9d0SgevP43EOtHRqT3+K9YyJF4I= X-Received: by 2002:a05:6512:3b14:b0:545:2c2c:5802 with SMTP id 2adb3069b0e04-54990ec1da0mr4456748e87.48.1741612960898; Mon, 10 Mar 2025 06:22:40 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250310-gpiochip-set-conversion-v1-0-03798bb833eb@linaro.org> <20250310-gpiochip-set-conversion-v1-4-03798bb833eb@linaro.org> <475375c9-9d72-4583-a21e-37b17c6b8c46@gmail.com> In-Reply-To: <475375c9-9d72-4583-a21e-37b17c6b8c46@gmail.com> From: Bartosz Golaszewski Date: Mon, 10 Mar 2025 14:22:29 +0100 X-Gm-Features: AQ5f1Jr6exc6jnbdN8OgJKfOfnFqkqPylc587CtLf_MV91ith_zm5SakUGtCL8Q Message-ID: Subject: Re: [PATCH 04/15] gpio: bd71828: use new line value setter callbacks To: Matti Vaittinen Cc: Ray Jui , Broadcom internal kernel review list , Linus Walleij , Florian Fainelli , Scott Branden , Marek Vasut , Michael Buesch , Thomas Richard , Eugeniy Paltsev , Benson Leung , Guenter Roeck , Andy Shevchenko , Support Opensource , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, chrome-platform@lists.linux.dev, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 10, 2025 at 2:20=E2=80=AFPM Matti Vaittinen wrote: > > > @@ -28,12 +27,10 @@ static void bd71828_gpio_set(struct gpio_chip *chip= , unsigned int offset, > > * we are dealing with - then we are done > > */ > > if (offset =3D=3D HALL_GPIO_OFFSET) > > - return; > > + return 0; > > Should this be -EINVAL (or, can this check be just dropped?) Value of an > input pin is tried to be set. > I don't want to break existing users but I did notice that and figured that we should rather check this in core GPIO code not each individual driver. I put that on my TODO list. Bart