From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <bartekgola@gmail.com>
Subject: Re: [PATCH v1] core: Relax gpiod_chip_open() for symbolic links
Date: Fri, 7 Feb 2020 14:00:10 +0100 [thread overview]
Message-ID: <CAMpxmJUHPH+6NRMCFUvtXiDW8nMksOuVrR6pV5LTUFTt_Of9WQ@mail.gmail.com> (raw)
In-Reply-To: <20200206181358.12805-1-andriy.shevchenko@linux.intel.com>
czw., 6 lut 2020 o 19:14 Andy Shevchenko
<andriy.shevchenko@linux.intel.com> napisał(a):
>
> User may ask device helper tool, for example, udev, to create a specific
> symbolic link to a device node. GPIO chip character device node is not
> exceptional. However, libgpiod in the commit d9b1c1f14c6b
> ("core: harden gpiod_chip_open()") went way too far in the hardening device
> node check.
>
> Relax that hardening for symbolic link to fix the regression.
>
> Reproducer:
>
> % gpioinfo /dev/gpiochip5
> gpiochip5 - 16 lines:
> line 0: "MUX33_DIR" "uart1-rx-oe" output active-high [used]
> ...
>
> % ln -sf /dev/gpiochip5 /dev/MyGPIO_5
>
> % gpioinfo /dev/MyGPIO_5
> gpioinfo: looking up chip /dev/MyGPIO_5: Inappropriate ioctl for device
>
> Link: https://stackoverflow.com/questions/60057494/gpio-issue-with-sym-link
> Fixes: d9b1c1f14c6b ("core: harden gpiod_chip_open()")
> Cc: Bartosz Golaszewski <bartekgola@gmail.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied and backported to v1.4.x and v1.5.x stable branches.
Thanks!
Bartosz
prev parent reply other threads:[~2020-02-07 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 18:13 [PATCH v1] core: Relax gpiod_chip_open() for symbolic links Andy Shevchenko
2020-02-07 10:13 ` Bartosz Golaszewski
2020-02-07 10:30 ` Andy Shevchenko
2020-02-07 11:01 ` Bartosz Golaszewski
2020-02-07 11:28 ` Andy Shevchenko
2020-02-07 12:05 ` Bartosz Gołaszewski
2020-02-07 13:00 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJUHPH+6NRMCFUvtXiDW8nMksOuVrR6pV5LTUFTt_Of9WQ@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartekgola@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).