From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
linux-gpio <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] gpio: bd71828: Remove unneeded defines for GPIO_LINE_DIRECTION_IN/OUT
Date: Tue, 4 Feb 2020 11:02:40 +0100 [thread overview]
Message-ID: <CAMpxmJUUCwtrh85oyMSYiJ3-saEe8wNQY03HHRODv_vueMeVWQ@mail.gmail.com> (raw)
In-Reply-To: <20200129123021.26200-1-axel.lin@ingics.com>
śr., 29 sty 2020 o 13:30 Axel Lin <axel.lin@ingics.com> napisał(a):
>
> They are defined in gpio/driver.h now.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/gpio/gpio-bd71828.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-bd71828.c b/drivers/gpio/gpio-bd71828.c
> index 04aade9e0a4d..3dbbc638e9a9 100644
> --- a/drivers/gpio/gpio-bd71828.c
> +++ b/drivers/gpio/gpio-bd71828.c
> @@ -10,16 +10,6 @@
> #define GPIO_OUT_REG(off) (BD71828_REG_GPIO_CTRL1 + (off))
> #define HALL_GPIO_OFFSET 3
>
> -/*
> - * These defines can be removed when
> - * "gpio: Add definition for GPIO direction"
> - * (9208b1e77d6e8e9776f34f46ef4079ecac9c3c25 in GPIO tree) gets merged,
> - */
> -#ifndef GPIO_LINE_DIRECTION_IN
> - #define GPIO_LINE_DIRECTION_IN 1
> - #define GPIO_LINE_DIRECTION_OUT 0
> -#endif
> -
> struct bd71828_gpio {
> struct rohm_regmap_dev chip;
> struct gpio_chip gpio;
> --
> 2.20.1
>
Applied for fixes. Thanks!
Bartosz
prev parent reply other threads:[~2020-02-04 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 12:30 [PATCH] gpio: bd71828: Remove unneeded defines for GPIO_LINE_DIRECTION_IN/OUT Axel Lin
2020-01-29 15:06 ` Vaittinen, Matti
2020-01-30 2:44 ` Axel Lin
2020-02-04 10:02 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJUUCwtrh85oyMSYiJ3-saEe8wNQY03HHRODv_vueMeVWQ@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=axel.lin@ingics.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).