* [PATCH] gpio: bd71828: Remove unneeded defines for GPIO_LINE_DIRECTION_IN/OUT
@ 2020-01-29 12:30 Axel Lin
2020-01-29 15:06 ` Vaittinen, Matti
2020-02-04 10:02 ` Bartosz Golaszewski
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2020-01-29 12:30 UTC (permalink / raw)
To: Linus Walleij; +Cc: Matti Vaittinen, Bartosz Golaszewski, linux-gpio, Axel Lin
They are defined in gpio/driver.h now.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-bd71828.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/gpio/gpio-bd71828.c b/drivers/gpio/gpio-bd71828.c
index 04aade9e0a4d..3dbbc638e9a9 100644
--- a/drivers/gpio/gpio-bd71828.c
+++ b/drivers/gpio/gpio-bd71828.c
@@ -10,16 +10,6 @@
#define GPIO_OUT_REG(off) (BD71828_REG_GPIO_CTRL1 + (off))
#define HALL_GPIO_OFFSET 3
-/*
- * These defines can be removed when
- * "gpio: Add definition for GPIO direction"
- * (9208b1e77d6e8e9776f34f46ef4079ecac9c3c25 in GPIO tree) gets merged,
- */
-#ifndef GPIO_LINE_DIRECTION_IN
- #define GPIO_LINE_DIRECTION_IN 1
- #define GPIO_LINE_DIRECTION_OUT 0
-#endif
-
struct bd71828_gpio {
struct rohm_regmap_dev chip;
struct gpio_chip gpio;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: bd71828: Remove unneeded defines for GPIO_LINE_DIRECTION_IN/OUT
2020-01-29 12:30 [PATCH] gpio: bd71828: Remove unneeded defines for GPIO_LINE_DIRECTION_IN/OUT Axel Lin
@ 2020-01-29 15:06 ` Vaittinen, Matti
2020-01-30 2:44 ` Axel Lin
2020-02-04 10:02 ` Bartosz Golaszewski
1 sibling, 1 reply; 4+ messages in thread
From: Vaittinen, Matti @ 2020-01-29 15:06 UTC (permalink / raw)
To: axel.lin@ingics.com, linus.walleij@linaro.org
Cc: linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com
On Wed, 2020-01-29 at 20:30 +0800, Axel Lin wrote:
> They are defined in gpio/driver.h now.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/gpio/gpio-bd71828.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-bd71828.c b/drivers/gpio/gpio-
> bd71828.c
> index 04aade9e0a4d..3dbbc638e9a9 100644
> --- a/drivers/gpio/gpio-bd71828.c
> +++ b/drivers/gpio/gpio-bd71828.c
> @@ -10,16 +10,6 @@
> #define GPIO_OUT_REG(off) (BD71828_REG_GPIO_CTRL1 + (off))
> #define HALL_GPIO_OFFSET 3
>
> -/*
> - * These defines can be removed when
> - * "gpio: Add definition for GPIO direction"
> - * (9208b1e77d6e8e9776f34f46ef4079ecac9c3c25 in GPIO tree) gets
> merged,
> - */
> -#ifndef GPIO_LINE_DIRECTION_IN
> - #define GPIO_LINE_DIRECTION_IN 1
> - #define GPIO_LINE_DIRECTION_OUT 0
> -#endif
>
Thanks once again for doing the cleanup! :)
Br,
Matti
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: bd71828: Remove unneeded defines for GPIO_LINE_DIRECTION_IN/OUT
2020-01-29 15:06 ` Vaittinen, Matti
@ 2020-01-30 2:44 ` Axel Lin
0 siblings, 0 replies; 4+ messages in thread
From: Axel Lin @ 2020-01-30 2:44 UTC (permalink / raw)
To: Vaittinen, Matti
Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
bgolaszewski@baylibre.com
Vaittinen, Matti <Matti.Vaittinen@fi.rohmeurope.com> 於 2020年1月29日 週三 下午11:06寫道：
>
>
> On Wed, 2020-01-29 at 20:30 +0800, Axel Lin wrote:
> > They are defined in gpio/driver.h now.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > ---
> > drivers/gpio/gpio-bd71828.c | 10 ----------
> > 1 file changed, 10 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-bd71828.c b/drivers/gpio/gpio-
> > bd71828.c
> > index 04aade9e0a4d..3dbbc638e9a9 100644
> > --- a/drivers/gpio/gpio-bd71828.c
> > +++ b/drivers/gpio/gpio-bd71828.c
> > @@ -10,16 +10,6 @@
> > #define GPIO_OUT_REG(off) (BD71828_REG_GPIO_CTRL1 + (off))
> > #define HALL_GPIO_OFFSET 3
> >
> > -/*
> > - * These defines can be removed when
> > - * "gpio: Add definition for GPIO direction"
> > - * (9208b1e77d6e8e9776f34f46ef4079ecac9c3c25 in GPIO tree) gets
> > merged,
> > - */
> > -#ifndef GPIO_LINE_DIRECTION_IN
> > - #define GPIO_LINE_DIRECTION_IN 1
> > - #define GPIO_LINE_DIRECTION_OUT 0
> > -#endif
> >
>
> Thanks once again for doing the cleanup! :)
Hi Matti,
Can you reply with your Ack?
It would be easier for maintainers to pick up the patch with Ack.
Thanks,
Axel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: bd71828: Remove unneeded defines for GPIO_LINE_DIRECTION_IN/OUT
2020-01-29 12:30 [PATCH] gpio: bd71828: Remove unneeded defines for GPIO_LINE_DIRECTION_IN/OUT Axel Lin
2020-01-29 15:06 ` Vaittinen, Matti
@ 2020-02-04 10:02 ` Bartosz Golaszewski
1 sibling, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2020-02-04 10:02 UTC (permalink / raw)
To: Axel Lin; +Cc: Linus Walleij, Matti Vaittinen, linux-gpio
śr., 29 sty 2020 o 13:30 Axel Lin <axel.lin@ingics.com> napisał(a):
>
> They are defined in gpio/driver.h now.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/gpio/gpio-bd71828.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-bd71828.c b/drivers/gpio/gpio-bd71828.c
> index 04aade9e0a4d..3dbbc638e9a9 100644
> --- a/drivers/gpio/gpio-bd71828.c
> +++ b/drivers/gpio/gpio-bd71828.c
> @@ -10,16 +10,6 @@
> #define GPIO_OUT_REG(off) (BD71828_REG_GPIO_CTRL1 + (off))
> #define HALL_GPIO_OFFSET 3
>
> -/*
> - * These defines can be removed when
> - * "gpio: Add definition for GPIO direction"
> - * (9208b1e77d6e8e9776f34f46ef4079ecac9c3c25 in GPIO tree) gets merged,
> - */
> -#ifndef GPIO_LINE_DIRECTION_IN
> - #define GPIO_LINE_DIRECTION_IN 1
> - #define GPIO_LINE_DIRECTION_OUT 0
> -#endif
> -
> struct bd71828_gpio {
> struct rohm_regmap_dev chip;
> struct gpio_chip gpio;
> --
> 2.20.1
>
Applied for fixes. Thanks!
Bartosz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-04 10:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-29 12:30 [PATCH] gpio: bd71828: Remove unneeded defines for GPIO_LINE_DIRECTION_IN/OUT Axel Lin
2020-01-29 15:06 ` Vaittinen, Matti
2020-01-30 2:44 ` Axel Lin
2020-02-04 10:02 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).