From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D14A8C2B9F4 for ; Fri, 25 Jun 2021 10:34:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B81C661439 for ; Fri, 25 Jun 2021 10:34:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231357AbhFYKgr (ORCPT ); Fri, 25 Jun 2021 06:36:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230436AbhFYKgq (ORCPT ); Fri, 25 Jun 2021 06:36:46 -0400 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11DCAC061574 for ; Fri, 25 Jun 2021 03:34:26 -0700 (PDT) Received: by mail-yb1-xb2c.google.com with SMTP id b64so3900231yba.0 for ; Fri, 25 Jun 2021 03:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dmRoCA65RV/48lXb3m2W6DafsVGVfuNgmtDKbzVBlOA=; b=FWC1UozMFhPqEhM/hP+0y5unvamFh2uadP93DvbTr2PyYZf/kVCF3ETNEZqEX8zTMB oIl80SOor1haIN3P9b/UQkx6fTTs7v9lnF4gvBhpRK85zzD3U5OIIveCV2JUx6UmCBui A1Up9ynYHTTM5KXy+cP1HKCUiRRKFBCqEGhbFWeC92EqwNghmAfdP7ts0TEv6SqjDdJo U5bglVx+8fc04q13Nez+t2G0Q/sRLHE6d2SpVr9qgTb4dpV/fj5BAQ0EHKpbA2mwnU8z hWAMZbljrgeZOURPYcC0dwnU5PS8MhIwF/OMMt3tvZGAgg2swVIxSbdKPoxqwhFis+Ps pABw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dmRoCA65RV/48lXb3m2W6DafsVGVfuNgmtDKbzVBlOA=; b=nSYAr5fZpWXwJQmFnkfjHXhKTqkY83hjPoU6Q9s35ZszPDHPNxIg8sFeb+H/Ihe1zK Xhr6EzS5OD+rC7gUxNrlCjF0QjEnr5c+IxbDa97hJmWG6dxjw+om63jMEpifRFwN2K9N m3yoxuXZ8Ocm8gwmcXfSkwBGgmCxFEPsP7v3THd3h0WcWGdQC70Mhxzr3cPuEjrFzIlD F1889J0gdXcgaDmvtmqSgiYpQURJkIkjAzfkKL25YhyX3swoZRq88oWfmXBDL/QsY02F REgmzLINPxpYZ1vh+bRIEZqVQEmhRB0DedH5ik07lxA5G8M8ssw8uB3O/8lFtaV4Uval 402w== X-Gm-Message-State: AOAM530X5I1H68phJ1xrerMpqNC7y+JK6tlvvCK9AEMWuB93NaFbobtr l/xVjiHEBFWHhvGyf1a2s7ScN9W9QySMwwjhE44GVQ== X-Google-Smtp-Source: ABdhPJxbFIO0pNolVnUaaWoQ6RTnzn35uYITFDDGruDFy0XC7E5sj/9OtjT5EajI6aCgtMbCf8DtfpJd/Ny8AINHHfQ= X-Received: by 2002:a25:738e:: with SMTP id o136mr11354409ybc.469.1624617265375; Fri, 25 Jun 2021 03:34:25 -0700 (PDT) MIME-Version: 1.0 References: <20210624101517.15167-1-wjc@cdjrlc.com> In-Reply-To: <20210624101517.15167-1-wjc@cdjrlc.com> From: Bartosz Golaszewski Date: Fri, 25 Jun 2021 12:34:14 +0200 Message-ID: Subject: Re: [PATCH v2] gpio: mxs: Prefer unsigned int to bare use of unsigned To: Jinchao Wang Cc: "andy.shevchenko" , shawnguo , "s.hauer" , linux-arm-kernel , linux-gpio , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Jun 24, 2021 at 12:15 PM Jinchao Wang wrote: > > Fix checkpatch warnings: > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > > Signed-off-by: Jinchao Wang > --- > - changes for v2: > - Use full prefix > > --- > drivers/gpio/gpio-mxs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c > index 524b668eb1ac..31a336b86ff2 100644 > --- a/drivers/gpio/gpio-mxs.c > +++ b/drivers/gpio/gpio-mxs.c > @@ -229,14 +229,14 @@ static int mxs_gpio_init_gc(struct mxs_gpio_port *port, int irq_base) > return rv; > } > > -static int mxs_gpio_to_irq(struct gpio_chip *gc, unsigned offset) > +static int mxs_gpio_to_irq(struct gpio_chip *gc, unsigned int offset) > { > struct mxs_gpio_port *port = gpiochip_get_data(gc); > > return irq_find_mapping(port->domain, offset); > } > > -static int mxs_gpio_get_direction(struct gpio_chip *gc, unsigned offset) > +static int mxs_gpio_get_direction(struct gpio_chip *gc, unsigned int offset) > { > struct mxs_gpio_port *port = gpiochip_get_data(gc); > u32 mask = 1 << offset; > -- > 2.31.1 > Applied, thanks! Bartosz