From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] gpio: max730x: Use the right include
Date: Mon, 23 Aug 2021 09:56:14 +0200 [thread overview]
Message-ID: <CAMpxmJV=bSCRiX5sBCDwoDPEnHMTuYoV+C3RXXLJpC2khLKM-w@mail.gmail.com> (raw)
In-Reply-To: <20210820225821.103070-1-linus.walleij@linaro.org>
On Sat, Aug 21, 2021 at 1:00 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> <linux/spi/max7301.h> despite the placement of the header, is
> used by drivers/gpio/gpio-max730*.
>
> The include needs struct gpio_chip and needs to include
> <linux/gpio/driver.h> not the legacy <linux/gpio.h> include.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> include/linux/spi/max7301.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/spi/max7301.h b/include/linux/spi/max7301.h
> index 433c20e2f46e..21449067aedb 100644
> --- a/include/linux/spi/max7301.h
> +++ b/include/linux/spi/max7301.h
> @@ -2,7 +2,7 @@
> #ifndef LINUX_SPI_MAX7301_H
> #define LINUX_SPI_MAX7301_H
>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
>
> /*
> * Some registers must be read back to modify.
> --
> 2.31.1
>
Applied, thanks!
Bartosz
prev parent reply other threads:[~2021-08-23 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 22:58 [PATCH] gpio: max730x: Use the right include Linus Walleij
2021-08-23 7:56 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMpxmJV=bSCRiX5sBCDwoDPEnHMTuYoV+C3RXXLJpC2khLKM-w@mail.gmail.com' \
--to=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).