* [PATCH] gpio: max730x: Use the right include
@ 2021-08-20 22:58 Linus Walleij
2021-08-23 7:56 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2021-08-20 22:58 UTC (permalink / raw)
To: linux-gpio, Bartosz Golaszewski; +Cc: Linus Walleij
<linux/spi/max7301.h> despite the placement of the header, is
used by drivers/gpio/gpio-max730*.
The include needs struct gpio_chip and needs to include
<linux/gpio/driver.h> not the legacy <linux/gpio.h> include.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
include/linux/spi/max7301.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/spi/max7301.h b/include/linux/spi/max7301.h
index 433c20e2f46e..21449067aedb 100644
--- a/include/linux/spi/max7301.h
+++ b/include/linux/spi/max7301.h
@@ -2,7 +2,7 @@
#ifndef LINUX_SPI_MAX7301_H
#define LINUX_SPI_MAX7301_H
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
/*
* Some registers must be read back to modify.
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: max730x: Use the right include
2021-08-20 22:58 [PATCH] gpio: max730x: Use the right include Linus Walleij
@ 2021-08-23 7:56 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2021-08-23 7:56 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio
On Sat, Aug 21, 2021 at 1:00 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> <linux/spi/max7301.h> despite the placement of the header, is
> used by drivers/gpio/gpio-max730*.
>
> The include needs struct gpio_chip and needs to include
> <linux/gpio/driver.h> not the legacy <linux/gpio.h> include.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> include/linux/spi/max7301.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/spi/max7301.h b/include/linux/spi/max7301.h
> index 433c20e2f46e..21449067aedb 100644
> --- a/include/linux/spi/max7301.h
> +++ b/include/linux/spi/max7301.h
> @@ -2,7 +2,7 @@
> #ifndef LINUX_SPI_MAX7301_H
> #define LINUX_SPI_MAX7301_H
>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
>
> /*
> * Some registers must be read back to modify.
> --
> 2.31.1
>
Applied, thanks!
Bartosz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-23 7:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-20 22:58 [PATCH] gpio: max730x: Use the right include Linus Walleij
2021-08-23 7:56 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).