From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60D03C43331 for ; Wed, 25 Mar 2020 12:54:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3200F2076A for ; Wed, 25 Mar 2020 12:54:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="N6DjDOyX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727381AbgCYMyl (ORCPT ); Wed, 25 Mar 2020 08:54:41 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:36784 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727279AbgCYMyl (ORCPT ); Wed, 25 Mar 2020 08:54:41 -0400 Received: by mail-qk1-f196.google.com with SMTP id d11so2350691qko.3 for ; Wed, 25 Mar 2020 05:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=povoSIiCw95ZWLQdoXVlSQBApcOXq2d8n4RLuzoEcos=; b=N6DjDOyXGLVrfhnKgSW6pYwhh4epm7TFTINbnybcohaJp7bpWPTjI0USi9+zwBuc4p hipSxYVV+rwwdBPFATtRmHNSbq9drmSshNOrWWnNWY4e35q5MzM11Qwz7JdPHTaEPVe7 KkYzRWmWACEsjLgnLFgr8k6IP1yNHynfTX9ojxWfu4rsZgNWab1eqnE/+6qnVxxf5g/c cBRRQKv9l3QLeOKufr0zjvgqkc1Ko0Frl7n8tWovOAjazwloVRwnp/PhfIH09D16tqUK KSTdpsGNkSk9VT+y0FZinFzhBd5Z/SrfhzUcTbHOsaNuA4UkOCbYnnJRJdzjAVMQ2GpA Ljsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=povoSIiCw95ZWLQdoXVlSQBApcOXq2d8n4RLuzoEcos=; b=JLDZfiwn/ouyTCLox1YnDCd2WcP6bl5GXUk2cnfE9Tm7dtXfTlmWaYrzegUsRCkION 1qABSSp2J+GTzvOdeu2HZ/vqSg21DCjwyDvBYvj41i4u5wNHbnRulxmhMQ4+X3AITV5h wiilmBo2hD2BH5qoE8LUv9CTx79x/PfAirxOCMG1ut26rYwImL9QTouIefr9PheSgGjr dDKrBNqtiuTSunQ/fryTMiaphvB/qZbAxvYgYJ0rz6zv0qQib+ZxdjkTjOaboPH7sUrX IBfK9cX15LwOWkslUlsOb7xxOKoaxipiklc/GcwAMzQtBEMM/FjDxbCm89Yc6uhPyVsK Viug== X-Gm-Message-State: ANhLgQ3xTlNYD9yexypXKZlA/ShLVZUmI2TsrmCfZYQGQlZlYR41Fg4t r7euMNtSSd9hIjNoYlW3H5tE+N2kqSykNwNnuLx2zQ== X-Google-Smtp-Source: ADFU+vtYWyCKpiV6HL9KoZ/zSAsthjsfi5/+bVjB5sm9Hxel0UpTO8bItfwOZbQ3YQBl3fq9NQJ/tKrAmphnLe+CO8M= X-Received: by 2002:a37:c444:: with SMTP id h4mr2801574qkm.120.1585140879852; Wed, 25 Mar 2020 05:54:39 -0700 (PDT) MIME-Version: 1.0 References: <20200325100439.14000-1-geert+renesas@glider.be> In-Reply-To: <20200325100439.14000-1-geert+renesas@glider.be> From: Bartosz Golaszewski Date: Wed, 25 Mar 2020 13:54:28 +0100 Message-ID: Subject: Re: [PATCH 0/2] gpiolib: gpio_set_config() cleanups To: Geert Uytterhoeven Cc: Linus Walleij , linux-gpio , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org =C5=9Br., 25 mar 2020 o 11:04 Geert Uytterhoeven napisa=C5=82(a): > > Hi Linus, Bartosz, > > This patch sets reworks the parameters for gpio_set_config() and > gpio_set_bias(), which simplifies callers, and slightly reduces the > number of lines of code. > > Thanks for your comments! > > Geert Uytterhoeven (2): > gpiolib: Pass gpio_desc to gpio_set_config() > gpiolib: Remove unused gpio_chip parameter from gpio_set_bias() > > drivers/gpio/gpiolib.c | 25 ++++++++++--------------- > 1 file changed, 10 insertions(+), 15 deletions(-) > > -- > 2.17.1 > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m6= 8k.org > > In personal conversations with technical people, I call myself a hacker. = But > when I'm talking to journalists I just say "programmer" or something like= that. > -- Linus Torv= alds Both look good to me. Reviewed-by: Bartosz Golaszewski