* [PATCH 7/7] gpiolib: Use spinlock_t instead of struct spinlock
[not found] <20190704153803.12739-1-bigeasy@linutronix.de>
@ 2019-07-04 15:38 ` Sebastian Andrzej Siewior
2019-07-05 9:33 ` Bartosz Golaszewski
2019-07-06 18:15 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2019-07-04 15:38 UTC (permalink / raw)
To: linux-kernel
Cc: tglx, Peter Zijlstra, Sebastian Andrzej Siewior, Linus Walleij,
Bartosz Golaszewski, linux-gpio
For spinlocks the type spinlock_t should be used instead of "struct
spinlock".
Use spinlock_t for spinlock's definition.
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/gpio/gpiolib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h
index 7a65dad43932c..7c52c2442173e 100644
--- a/drivers/gpio/gpiolib.h
+++ b/drivers/gpio/gpiolib.h
@@ -210,7 +210,7 @@ int gpiod_set_array_value_complex(bool raw, bool can_sleep,
struct gpio_array *array_info,
unsigned long *value_bitmap);
-extern struct spinlock gpio_lock;
+extern spinlock_t gpio_lock;
extern struct list_head gpio_devices;
struct gpio_desc {
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 7/7] gpiolib: Use spinlock_t instead of struct spinlock
2019-07-04 15:38 ` [PATCH 7/7] gpiolib: Use spinlock_t instead of struct spinlock Sebastian Andrzej Siewior
@ 2019-07-05 9:33 ` Bartosz Golaszewski
2019-07-06 18:15 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2019-07-05 9:33 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: LKML, Thomas Gleixner, Peter Zijlstra, Linus Walleij, linux-gpio
czw., 4 lip 2019 o 17:38 Sebastian Andrzej Siewior
<bigeasy@linutronix.de> napisał(a):
>
> For spinlocks the type spinlock_t should be used instead of "struct
> spinlock".
>
> Use spinlock_t for spinlock's definition.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> drivers/gpio/gpiolib.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h
> index 7a65dad43932c..7c52c2442173e 100644
> --- a/drivers/gpio/gpiolib.h
> +++ b/drivers/gpio/gpiolib.h
> @@ -210,7 +210,7 @@ int gpiod_set_array_value_complex(bool raw, bool can_sleep,
> struct gpio_array *array_info,
> unsigned long *value_bitmap);
>
> -extern struct spinlock gpio_lock;
> +extern spinlock_t gpio_lock;
> extern struct list_head gpio_devices;
>
> struct gpio_desc {
> --
> 2.20.1
>
Thanks for spotting that!
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 7/7] gpiolib: Use spinlock_t instead of struct spinlock
2019-07-04 15:38 ` [PATCH 7/7] gpiolib: Use spinlock_t instead of struct spinlock Sebastian Andrzej Siewior
2019-07-05 9:33 ` Bartosz Golaszewski
@ 2019-07-06 18:15 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-07-06 18:15 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: linux-kernel@vger.kernel.org, Thomas Gleixner, Peter Zijlstra,
Bartosz Golaszewski, open list:GPIO SUBSYSTEM
On Thu, Jul 4, 2019 at 5:38 PM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> For spinlocks the type spinlock_t should be used instead of "struct
> spinlock".
>
> Use spinlock_t for spinlock's definition.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Patch applied with Bartosz' ACK!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-06 18:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190704153803.12739-1-bigeasy@linutronix.de>
2019-07-04 15:38 ` [PATCH 7/7] gpiolib: Use spinlock_t instead of struct spinlock Sebastian Andrzej Siewior
2019-07-05 9:33 ` Bartosz Golaszewski
2019-07-06 18:15 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).