* [PATCH 35/62] gpio: gpio-rcar: Use new GPIO_LINE_DIRECTION [not found] <cover.1572945879.git.matti.vaittinen@fi.rohmeurope.com> @ 2019-11-05 10:28 ` Matti Vaittinen 2019-11-05 10:32 ` Geert Uytterhoeven 0 siblings, 1 reply; 2+ messages in thread From: Matti Vaittinen @ 2019-11-05 10:28 UTC (permalink / raw) To: matti.vaittinen, mazziesaccount Cc: Linus Walleij, Bartosz Golaszewski, linux-gpio, linux-kernel It's hard for occasional GPIO code reader/writer to know if values 0/1 equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and GPIO_LINE_DIRECTION_OUT to help them out. Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> --- drivers/gpio/gpio-rcar.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c index 187984d26f47..d7e6e68c25af 100644 --- a/drivers/gpio/gpio-rcar.c +++ b/drivers/gpio/gpio-rcar.c @@ -279,7 +279,10 @@ static int gpio_rcar_get_direction(struct gpio_chip *chip, unsigned int offset) { struct gpio_rcar_priv *p = gpiochip_get_data(chip); - return !(gpio_rcar_read(p, INOUTSEL) & BIT(offset)); + if (gpio_rcar_read(p, INOUTSEL) & BIT(offset)) + return GPIO_LINE_DIRECTION_OUT; + + return GPIO_LINE_DIRECTION_IN; } static int gpio_rcar_direction_input(struct gpio_chip *chip, unsigned offset) -- 2.21.0 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =] ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 35/62] gpio: gpio-rcar: Use new GPIO_LINE_DIRECTION 2019-11-05 10:28 ` [PATCH 35/62] gpio: gpio-rcar: Use new GPIO_LINE_DIRECTION Matti Vaittinen @ 2019-11-05 10:32 ` Geert Uytterhoeven 0 siblings, 0 replies; 2+ messages in thread From: Geert Uytterhoeven @ 2019-11-05 10:32 UTC (permalink / raw) To: Matti Vaittinen Cc: Matti Vaittinen, Linus Walleij, Bartosz Golaszewski, open list:GPIO SUBSYSTEM, Linux Kernel Mailing List On Tue, Nov 5, 2019 at 11:29 AM Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> wrote: > It's hard for occasional GPIO code reader/writer to know if values 0/1 > equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and > GPIO_LINE_DIRECTION_OUT to help them out. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-05 10:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1572945879.git.matti.vaittinen@fi.rohmeurope.com>
2019-11-05 10:28 ` [PATCH 35/62] gpio: gpio-rcar: Use new GPIO_LINE_DIRECTION Matti Vaittinen
2019-11-05 10:32 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).