From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH/RFC 1/4] pinctrl: sh-pfc: Add PINMUX_SINGLE() Date: Mon, 30 Nov 2015 11:44:51 +0100 Message-ID: References: <1445369195-25117-1-git-send-email-geert+renesas@glider.be> <1445369195-25117-2-git-send-email-geert+renesas@glider.be> <3546719.xIF05iocVT@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ob0-f172.google.com ([209.85.214.172]:35949 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752885AbbK3Kow (ORCPT ); Mon, 30 Nov 2015 05:44:52 -0500 In-Reply-To: <3546719.xIF05iocVT@avalon> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Laurent Pinchart Cc: Geert Uytterhoeven , Kuninori Morimoto , Linus Walleij , Linux-sh list , "linux-gpio@vger.kernel.org" Hi Laurent, On Wed, Nov 25, 2015 at 1:49 AM, Laurent Pinchart wrote: > On Tuesday 20 October 2015 21:26:32 Geert Uytterhoeven wrote: >> Add a macro to describe a pinmux configuration for a single-function >> pin. >> >> Signed-off-by: Geert Uytterhoeven >> --- >> drivers/pinctrl/sh-pfc/sh_pfc.h | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h >> b/drivers/pinctrl/sh-pfc/sh_pfc.h index 63e6cd050d0fb7d2..932fbef8bad400dd >> 100644 >> --- a/drivers/pinctrl/sh-pfc/sh_pfc.h >> +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h >> @@ -277,6 +277,13 @@ struct sh_pfc_soc_info { >> PINMUX_DATA(fn##_MARK, FN_##ms, FN_##ipsr, FN_##fn) >> >> /* >> + * Describe a pinmux configuration for a single-function pin. > > I would say "single-function pin with GPIO capability". OK, makes sense, so will update. Note that there's usually an exception to every rule ("PENC1" on r8a7779 ;-). > Apart from that, > > Acked-by: Laurent Pinchart Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds