linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Sergey Shtylyov <s.shtylyov@omp.ru>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	dmaengine <dmaengine@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
	Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH 06/16] dt-bindings: serial: renesas,scif: Document RZ/V2L SoC
Date: Tue, 11 Jan 2022 17:22:58 +0100	[thread overview]
Message-ID: <CAMuHMdUB-wK_0Vqn4fmqQ0jaHWmo9OTRPT1bwWsZh76U1J729A@mail.gmail.com> (raw)
In-Reply-To: <20211221094717.16187-7-prabhakar.mahadev-lad.rj@bp.renesas.com>

Hi Prabhakar,

On Tue, Dec 21, 2021 at 10:48 AM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> Add SCIF binding documentation for Renesas RZ/V2L SoC. SCIF block on RZ/V2L
> is identical to one found on the RZ/G2L SoC. No driver changes are required
> as RZ/G2L compatible string "renesas,scif-r9a07g044" will be used as a
> fallback.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> @@ -67,6 +67,12 @@ properties:
>        - items:
>            - enum:
>                - renesas,scif-r9a07g044      # RZ/G2{L,LC}
> +              - renesas,scif-r9a07g054      # RZ/V2L

As the idea is to rely on the RZ/G2L fallback for matching, cfr. below,
the above addition is not needed or wanted.

> +
> +      - items:
> +          - enum:
> +              - renesas,scif-r9a07g054      # RZ/V2L
> +          - const: renesas,scif-r9a07g044   # RZ/G2{L,LC} fallback for RZ/V2L
>
>    reg:
>      maxItems: 1
> @@ -154,6 +160,7 @@ if:
>            - renesas,rcar-gen2-scif
>            - renesas,rcar-gen3-scif
>            - renesas,scif-r9a07g044
> +          - renesas,scif-r9a07g054

This addition is not needed if the fallback is always present.

>  then:
>    required:
>      - resets

Given Greg already applied your patch, I think you have to send a
follow-up patch.
Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  parent reply	other threads:[~2022-01-11 16:23 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21  9:47 [PATCH 00/16] Add new Renesas RZ/V2L SoC and Renesas RZ/V2L SMARC EVK support Lad Prabhakar
2021-12-21  9:47 ` [PATCH 01/16] dt-bindings: arm: renesas: Document Renesas RZ/V2L SoC Lad Prabhakar
2021-12-22 18:20   ` Rob Herring
2021-12-22 18:22   ` Rob Herring
2021-12-22 19:10     ` Lad, Prabhakar
2022-01-21 14:43   ` Geert Uytterhoeven
2021-12-21  9:47 ` [PATCH 02/16] dt-bindings: arm: renesas: Document SMARC EVK Lad Prabhakar
2021-12-22 18:23   ` Rob Herring
2021-12-22 19:37     ` Lad, Prabhakar
2022-01-21 14:44   ` Geert Uytterhoeven
2021-12-21  9:47 ` [PATCH 03/16] dt-bindings: power: renesas,rzg2l-sysc: Document RZ/V2L SoC Lad Prabhakar
2021-12-22 18:24   ` Rob Herring
2021-12-21  9:47 ` [PATCH 04/16] soc: renesas: Identify " Lad Prabhakar
2021-12-21  9:47 ` [PATCH 05/16] arm64: renesas_defconfig: Enable ARCH_R9A07G054 Lad Prabhakar
2021-12-21  9:47 ` [PATCH 06/16] dt-bindings: serial: renesas,scif: Document RZ/V2L SoC Lad Prabhakar
2021-12-22 18:25   ` Rob Herring
2022-01-11 16:22   ` Geert Uytterhoeven [this message]
2022-01-15  1:46     ` Lad, Prabhakar
2021-12-21  9:47 ` [PATCH 07/16] dt-bindings: serial: renesas,sci: " Lad Prabhakar
2021-12-22 18:25   ` Rob Herring
2022-01-11 16:15   ` Geert Uytterhoeven
2021-12-21  9:47 ` [PATCH 08/16] dt-bindings: clock: Add R9A07G054 CPG Clock and Reset Definitions Lad Prabhakar
2021-12-22 18:25   ` Rob Herring
2021-12-21  9:47 ` [PATCH 09/16] dt-bindings: clock: renesas: Document RZ/V2L SoC Lad Prabhakar
2021-12-22 18:26   ` Rob Herring
2021-12-21  9:47 ` [PATCH 10/16] clk: renesas: Add support for " Lad Prabhakar
2021-12-21  9:47 ` [PATCH 11/16] dt-bindings: pinctrl: renesas: Document RZ/V2L pinctrl Lad Prabhakar
2021-12-21 14:36   ` Rob Herring
2021-12-22 18:27   ` Rob Herring
2021-12-21  9:47 ` [PATCH 12/16] pinctrl: renesas: Kconfig: Select PINCTRL_RZG2L if RZ/V2L SoC is enabled Lad Prabhakar
2021-12-21  9:47 ` [PATCH 13/16] dt-bindings: dma: rz-dmac: Document RZ/V2L SoC Lad Prabhakar
2021-12-22 18:27   ` Rob Herring
2021-12-21  9:47 ` [PATCH 14/16] dt-bindings: net: renesas,etheravb: " Lad Prabhakar
2021-12-22 18:28   ` Rob Herring
2021-12-21  9:47 ` [PATCH 15/16] arm64: dts: renesas: Add initial DTSI for " Lad Prabhakar
2021-12-21  9:47 ` [PATCH 16/16] arm64: dts: renesas: Add initial device tree for RZ/V2L SMARC EVK Lad Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdUB-wK_0Vqn4fmqQ0jaHWmo9OTRPT1bwWsZh76U1J729A@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=netdev@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=s.shtylyov@omp.ru \
    --cc=sboyd@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).