Re: [PATCH] gpio-rcar: .irq_set_wake() support to work with suspend_device_irqs()

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Magnus, Kaneko-san,

On Mon, Nov 17, 2014 at 2:06 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> On Fri, Nov 14, 2014 at 6:53 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Fri, Nov 7, 2014 at 10:22 AM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
>>> From: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
>>>
>>> All IRQs in the kernel get disabled by PM core prior to .suspend_noirq()
>>> step through kernel/irq/pm.c::suspend_device_irqs().
>>>
>>> The SYSC hardware block in the R-Car SoCs, on the other hand, uses any
>>> interrupt as wake-up source(es) and requires them to be unmasked during
>>> the system is suspended.
>>>
>>> This patch implements .irq_set_wake() which makes __disable_irq() call
>>> a NOP when a GPIO port is claimed as a wake-up source.
>>>
>>> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
>>> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
>>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>>
>> Patch tentatively applied unless Magnus or Laurent starts complaining...
>
> I'll bite. =)
>
> Thanks for the efforts, but I doubt that this patch is needed. Unless
> I'm mistaken this feature is implemented already in the following
> commits:
>
> 4039611 gpio: rcar: Enable mask on suspend
> fba968a gpio: rcar: Use lazy disable

Good to see you (as the author of the driver and those two fixes) have some
reservations. I also had my doubts about this patch, but I didn't get to
testing it earlier...

I can confirm resume from s2ram works without and with this patch.
So unless this patch is meant to fix something else (is it?), I think it can be
dropped.

>> This driver should be simple to convert to GPIOLIB_IRQCHIP and get
>> rid of some code overhead.
>
> Perhaps Geert [CC:ed] can have a look at this in the not so distant future?

Sure. Will do.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds