From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9950FEB64DC for ; Mon, 17 Jul 2023 07:43:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229796AbjGQHns convert rfc822-to-8bit (ORCPT ); Mon, 17 Jul 2023 03:43:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjGQHnr (ORCPT ); Mon, 17 Jul 2023 03:43:47 -0400 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE290FE; Mon, 17 Jul 2023 00:43:46 -0700 (PDT) Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-635e0e6b829so30051486d6.0; Mon, 17 Jul 2023 00:43:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689579825; x=1692171825; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5LWJf53shp0viE9TAbmwOxmgVvdOZl/M9mic33WO7Jo=; b=jicA2NoVDvuNU2zQuob2Km7LnEuNhCoXF4m96iiv4fJCJTYiylGaeOaEdG7IN3+Esq cKQ2Z+8rZx8nwQsLVugi5hFgkvO2Y8NKJB8t8mXxqmYM0j5Qtja0ufeP8M8/GYtFf7WV E3VGAFhG+N+DQs/HrZmwgvKVD4M8NAyiJGwx0xwnjImr18Cc0tnavJjBoHoDyK3pP/Xa 1tRSm3KmdRqEJcTXGQHL2VFSDYVWNXVGYW2zdC1pX6STMRRKTAmZljbZmuyL0DFyXG6e nXDhHhaLs3C/P64b2Y1SYYHosaNU5umbAGUbhPgLmZ7QpID+BOIICDoLBANvYMVT5sL1 eqAA== X-Gm-Message-State: ABy/qLbqBXk3jUbQIaWi2HK+DV2vlZVmQPT0rqYAksQ5UaUMLWl9cF0t ZYEVr/4d/GbozF06SwW8jvfdLhzfp5TP4w== X-Google-Smtp-Source: APBJJlEG5NUi4cYO92qKx8Mr1uGDbzFpPh1ZZJ5f31be6u4InjhyEjUwpON4eQXK3SkN0ld9KgEVOQ== X-Received: by 2002:a0c:b31b:0:b0:635:dbb4:853e with SMTP id s27-20020a0cb31b000000b00635dbb4853emr10008229qve.54.1689579825644; Mon, 17 Jul 2023 00:43:45 -0700 (PDT) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com. [209.85.160.177]) by smtp.gmail.com with ESMTPSA id t2-20020a0cb702000000b0061a68b5a8c4sm6296520qvd.134.2023.07.17.00.43.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jul 2023 00:43:45 -0700 (PDT) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-403af7dfa3aso36291641cf.0; Mon, 17 Jul 2023 00:43:45 -0700 (PDT) X-Received: by 2002:a25:2945:0:b0:c21:caaf:bd47 with SMTP id p66-20020a252945000000b00c21caafbd47mr10530962ybp.2.1689579804817; Mon, 17 Jul 2023 00:43:24 -0700 (PDT) MIME-Version: 1.0 References: <20230714174901.4062397-1-robh@kernel.org> In-Reply-To: <20230714174901.4062397-1-robh@kernel.org> From: Geert Uytterhoeven Date: Mon, 17 Jul 2023 09:43:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] pinctrl: Explicitly include correct DT includes To: Rob Herring Cc: Linus Walleij , Ray Jui , Scott Branden , Broadcom internal kernel review list , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer , NXP Linux Team , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Chester Lin , NXP S32 Linux Team , Chen-Yu Tsai , Damien Le Moal , Vladimir Zapolskiy , Heiko Stuebner , Tony Lindgren , Haojian Zhuang , Daniel Mack , Robert Jarzmik , Andy Gross , Bjorn Andersson , Konrad Dybcio , Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Viresh Kumar , Shiraz Hashim , soc@kernel.org, Orson Zhai , Baolin Wang , Chunyan Zhang , Emil Renner Berthing , Jianlong Huang , Maxime Coquelin , Alexandre Torgue , Dvorkin Dmitry , Wells Lu , Jernej Skrabec , Samuel Holland , Thierry Reding , Jonathan Hunter , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-riscv@lists.infradead.org, linux-oxnas@groups.io, linux-rockchip@lists.infradead.org, linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Jul 14, 2023 at 7:52 PM Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > drivers/pinctrl/renesas/core.c | 1 - > drivers/pinctrl/renesas/pinctrl-rza1.c | 3 +-- > drivers/pinctrl/renesas/pinctrl-rza2.c | 3 ++- > drivers/pinctrl/renesas/pinctrl-rzg2l.c | 3 ++- > drivers/pinctrl/renesas/pinctrl-rzv2m.c | 3 ++- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds