From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08415C41513 for ; Thu, 17 Aug 2023 12:48:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350949AbjHQMrr convert rfc822-to-8bit (ORCPT ); Thu, 17 Aug 2023 08:47:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350947AbjHQMrW (ORCPT ); Thu, 17 Aug 2023 08:47:22 -0400 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1367A2D5F; Thu, 17 Aug 2023 05:47:21 -0700 (PDT) Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-58c6b6b4953so20629207b3.3; Thu, 17 Aug 2023 05:47:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692276440; x=1692881240; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K7jILR1Ve6WmZPM9OZvcCN6Ef1BytUgkOlnaEG52+hM=; b=QP9845KhKNduy8vf+Kch3NHMkXVmRSmGWK7MCFZ/gelSfKMlIJ8VcXxb5/tBVlmbOC 1ySwKZQGEEISW0MOXz3g7x/C7VbwgVnjHWMD0RljeZCfDJBncT66mRbrja9Z3l8gIi8R RZcI9XeWsQdcmqXlubtKP66KpT6OFcq5ix6MM9TNVF2jkijtSZrjt/PGQV8OBZKFiHPt QdXAYCDobp+7fCGosEIhvBDW2Wtb2mHnPltWLpouR26m9uovie510scoLm6MYY72JIGb Da+yqaALkEQZLvTp8EtRoa8N+dpHW9kn6RUzoXcpRslOJrNqRi/0H+X4a8c8hYFXFYp8 bSSw== X-Gm-Message-State: AOJu0YxGQvbpB42eFkLv20vHhbqzCHeP8J9zsjPkXH4vW5Zxv/lvmnkr bMJ9v+xNkOH5LixpQaTEgO+FXRVgFlQaAA== X-Google-Smtp-Source: AGHT+IHyKxXICHUPK7IScJnsf/OKJUnn7xNxWubEywO9CoVh+07BdHO3N7gkJdDlS+Zq3afZX4S6gA== X-Received: by 2002:a81:9245:0:b0:58b:cea5:947a with SMTP id j66-20020a819245000000b0058bcea5947amr4951432ywg.40.1692276439983; Thu, 17 Aug 2023 05:47:19 -0700 (PDT) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com. [209.85.219.176]) by smtp.gmail.com with ESMTPSA id x81-20020a81a054000000b0058cbf72d6f2sm925060ywg.119.2023.08.17.05.47.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Aug 2023 05:47:19 -0700 (PDT) Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-d73c595b558so242109276.2; Thu, 17 Aug 2023 05:47:19 -0700 (PDT) X-Received: by 2002:a05:6902:724:b0:d6b:78fe:f1c1 with SMTP id l4-20020a056902072400b00d6b78fef1c1mr5721279ybt.65.1692276439203; Thu, 17 Aug 2023 05:47:19 -0700 (PDT) MIME-Version: 1.0 References: <20230815131558.33787-1-biju.das.jz@bp.renesas.com> <20230815131558.33787-4-biju.das.jz@bp.renesas.com> In-Reply-To: <20230815131558.33787-4-biju.das.jz@bp.renesas.com> From: Geert Uytterhoeven Date: Thu, 17 Aug 2023 14:47:07 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 3/3] pinctrl: renesas: rza2: Add lock around pinctrl_generic{{add,remove}_group,{add,remove}_function} To: Biju Das Cc: Linus Walleij , Chris Brandt , Jacopo Mondi , linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, Fabrizio Castro , Prabhakar Mahadev Lad , stable@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Aug 15, 2023 at 3:16 PM Biju Das wrote: > The pinctrl group and function creation/remove calls expect > caller to take care of locking. Add lock around these functions. > > Fixes: b59d0e782706 ("pinctrl: Add RZ/A2 pin and gpio controller") > Cc: stable@kernel.org > Signed-off-by: Biju Das > --- > v2->v3: > * Added unlock_and_done label for lock error path. Reviewed-by: Geert Uytterhoeven i.e. will queue in renesas-pinctrl-for-v6.6. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds