From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A39BC433DB for ; Tue, 22 Dec 2020 09:33:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DA0523103 for ; Tue, 22 Dec 2020 09:33:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725783AbgLVJdF (ORCPT ); Tue, 22 Dec 2020 04:33:05 -0500 Received: from mail-ot1-f43.google.com ([209.85.210.43]:38080 "EHLO mail-ot1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbgLVJdF (ORCPT ); Tue, 22 Dec 2020 04:33:05 -0500 Received: by mail-ot1-f43.google.com with SMTP id j20so11360944otq.5; Tue, 22 Dec 2020 01:32:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=38MtaZHIDmudmqIZ8gHcMo45fVQIBHSmoA9LJPMdAO4=; b=rWM4gABgGtacr2N5/Tati8HS/0Eo0Ri4IliyLJMgbgCGHvVtMIxaTWO5SLSRqXnWDc VCJSj2zSKD2tUDlLZaNYrM4hmeLkuOxzlfF+iXAlj9xvvPdlp6Jf1oXo/XNtim+0OBVs OHW3thBmxq34j/fdzCx1sMnbU2Wdl2TT7B015NQ3Rsi5ifutHVfwB3FhK7DlJt09/Ji0 hd74tpY1jd9D1h3N3wGph9bHUzwR3grBx2kLmYWeBeq49RhW/T6+OTiryn1OyvtGoL6e 2d6tKCsCFVW4P4tpqXgkZBFv6f05//1Ps0IgSRb10pc6Ns1OP4LHoZagk3R1c1bE2GyJ Icig== X-Gm-Message-State: AOAM531DW6T0RBigb2FAXqEuTFXB0jdBNfbytiQBT0Pp8CsgPFvt89a8 ArQMcd0/7/svTCLsuNhHJ7BRCjZbx//gR+mCp/4= X-Google-Smtp-Source: ABdhPJydRDEvLH99mFgwELsiqtHRp/UzEEDf0IQthSZGw5hLHZcYYzMAJ6AXeYJJ3hPE4jmiQecVVNsuJ9yFxL/rui0= X-Received: by 2002:a05:6830:1f5a:: with SMTP id u26mr15083149oth.250.1608629544422; Tue, 22 Dec 2020 01:32:24 -0800 (PST) MIME-Version: 1.0 References: <1608519279-13341-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1608519279-13341-13-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 22 Dec 2020 10:32:13 +0100 Message-ID: Subject: Re: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF To: Yoshihiro Shimoda Cc: Marek Vasut , Lee Jones , Matti Vaittinen , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Khiem Nguyen , linux-power , "open list:GPIO SUBSYSTEM" , Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Shimoda-san, On Tue, Dec 22, 2020 at 10:23 AM Yoshihiro Shimoda wrote: > > From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 5:53 PM > > On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda > > wrote: > > > > --- a/drivers/mfd/bd9571mwv.c > > > +++ b/drivers/mfd/bd9571mwv.c > > > > > @@ -200,12 +277,14 @@ static int bd9571mwv_probe(struct i2c_client *client, > > > > > > static const struct of_device_id bd9571mwv_of_match_table[] = { > > > { .compatible = "rohm,bd9571mwv", }, > > > + { .compatible = "rohm,bd9574mwf", }, > > > { /* sentinel */ } > > > }; > > > MODULE_DEVICE_TABLE(of, bd9571mwv_of_match_table); > > > > > > static const struct i2c_device_id bd9571mwv_id_table[] = { > > > - { "bd9571mwv", 0 }, > > > + { "bd9571mwv", ROHM_CHIP_TYPE_BD9571 }, > > > + { "bd9574mwf", ROHM_CHIP_TYPE_BD9574 }, > > > > Why add the chip types? These are unused, and the driver uses > > autodetection of the chip variant anyway. > > I just added the chip types in the future use. As you said, > these are unused and we should not add a future use in general. > So, I'll remove this change. OK. > Also, I think I should remove the following patch. > > [PATCH v4 08/12] gpio: bd9571mwv: Add BD9574MWF support You mean removing the chip types from bd9571mwv_gpio_id_table[]? You still need the "bd9574mwf-gpio" entry, don't you? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds