From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] pinctrl: renesas: Initial R8A779G0 (V4H) PFC support
Date: Tue, 14 Jun 2022 08:55:55 +0200 [thread overview]
Message-ID: <CAMuHMdUhz==kdNejHh9t15cRVLxyxamsj4APOU6gz1p5H9-=DA@mail.gmail.com> (raw)
In-Reply-To: <877d5kkuiq.wl-kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san,
On Tue, Jun 14, 2022 at 1:34 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> > > +#define CPU_ALL_GP(fn, sfx) \
> > > + PORT_GP_CFG_19(0, fn, sfx, CFG_FLAGS | SH_PFC_PIN_CFG_IO_VOLTAGE_18_33), \
> > > + PORT_GP_CFG_29(1, fn, sfx, CFG_FLAGS | SH_PFC_PIN_CFG_IO_VOLTAGE_18_33), \
> >
> > GP1_23 to GP1_28 do not support voltage control.
> (snip)
> > "<= RCAR_GP_PIN(1, 22)", as GP1_23 to GP1_28 do not support voltage
> > control.
>
> Am I missing something ?
> I guess GP1_23 to GP1_28 are same as other GP1_xxx.
Table 7.28 ("Configuration of Registers in POC0 , POC1") documents
voltage control bits in POC1 for bits 0-22 only.
However, the pin function spreadsheet says GP1_23 to GP1_28 are
1.8/3.3V.
Which one is correct?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2022-06-14 6:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 1:06 [PATCH v2 0/4] pinctrl: renesas: r8a779g0: Add pins, groups and functions Kuninori Morimoto
2022-06-07 1:06 ` [PATCH v2 1/4] dt-bindings: pinctrl: renesas,pfc: Document r8a779g0 support Kuninori Morimoto
2022-06-09 9:58 ` Geert Uytterhoeven
2022-06-07 1:07 ` [PATCH v2 2/4] pinctrl: renesas: Add PORT_GP_CFG_13 macros Kuninori Morimoto
2022-06-09 9:58 ` Geert Uytterhoeven
2022-06-07 1:07 ` [PATCH v2 3/4] pinctrl: renesas: Initial R8A779G0 (V4H) PFC support Kuninori Morimoto
2022-06-10 11:43 ` Geert Uytterhoeven
2022-06-10 15:57 ` Geert Uytterhoeven
2022-06-12 23:51 ` Kuninori Morimoto
2022-06-13 15:18 ` Geert Uytterhoeven
2022-06-13 23:23 ` Kuninori Morimoto
2022-06-13 23:34 ` Kuninori Morimoto
2022-06-14 6:55 ` Geert Uytterhoeven [this message]
2022-06-15 22:17 ` Kuninori Morimoto
2022-06-13 15:08 ` Geert Uytterhoeven
2022-06-07 1:07 ` [PATCH v2 4/4] pinctrl: renesas: r8a779g0: Add pins, groups and functions Kuninori Morimoto
2022-06-09 16:30 ` Geert Uytterhoeven
2022-06-09 23:28 ` Kuninori Morimoto
2022-06-10 15:53 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUhz==kdNejHh9t15cRVLxyxamsj4APOU6gz1p5H9-=DA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).