* [PATCH] pinctrl: renesas: pinctrl-rzv2m: remove unnecessary check from rzv2m_dt_node_to_map()
@ 2022-11-08 18:32 Biju Das
2022-11-14 14:07 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Biju Das @ 2022-11-08 18:32 UTC (permalink / raw)
To: Linus Walleij
Cc: Biju Das, Geert Uytterhoeven, linux-renesas-soc, linux-gpio,
Chris Paterson, Fabrizio Castro
This patch removes the unnecessary check from rzv2m_dt_node_to_map()
as the ret value is already negative.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
drivers/pinctrl/renesas/pinctrl-rzv2m.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pinctrl/renesas/pinctrl-rzv2m.c b/drivers/pinctrl/renesas/pinctrl-rzv2m.c
index e8c18198bebd..62e911b7d007 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzv2m.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzv2m.c
@@ -397,8 +397,7 @@ static int rzv2m_dt_node_to_map(struct pinctrl_dev *pctldev,
ret = -EINVAL;
done:
- if (ret < 0)
- rzv2m_dt_free_map(pctldev, *map, *num_maps);
+ rzv2m_dt_free_map(pctldev, *map, *num_maps);
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: renesas: pinctrl-rzv2m: remove unnecessary check from rzv2m_dt_node_to_map()
2022-11-08 18:32 [PATCH] pinctrl: renesas: pinctrl-rzv2m: remove unnecessary check from rzv2m_dt_node_to_map() Biju Das
@ 2022-11-14 14:07 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2022-11-14 14:07 UTC (permalink / raw)
To: biju.das.jz
Cc: Linus Walleij, linux-renesas-soc, linux-gpio, Chris Paterson,
Fabrizio Castro
On Tue, Nov 8, 2022 at 7:32 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> This patch removes the unnecessary check from rzv2m_dt_node_to_map()
> as the ret value is already negative.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-pinctrl-for-v6.2.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-14 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-08 18:32 [PATCH] pinctrl: renesas: pinctrl-rzv2m: remove unnecessary check from rzv2m_dt_node_to_map() Biju Das
2022-11-14 14:07 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).