From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Ralph Siemsen <ralph.siemsen@linaro.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: renesas: rzn1: enable PINMUX
Date: Thu, 5 Oct 2023 09:10:39 +0200 [thread overview]
Message-ID: <CAMuHMdVEhVX8bcCVNYRuzdOpiW64dBELJp0ncdYsZUg4LLFLeA@mail.gmail.com> (raw)
In-Reply-To: <20231004200008.1306798-1-ralph.siemsen@linaro.org>
Hi Ralph,
On Wed, Oct 4, 2023 at 10:00 PM Ralph Siemsen <ralph.siemsen@linaro.org> wrote:
> Enable pin muxing (eg. programmable function), so that the RZN1 GPIO
> pins will be configured as specified by the pinmux in the DTS.
>
> This used to be enabled implicitly via CONFIG_GENERIC_PINMUX_FUNCTIONS,
> however that was removed in 308fb4e4eae14e6189dece3b7cf5b5f453c5d02
You missed the first character of the commit ID.
> since the rzn1 driver does not call any of the generic pinmux functions.
>
> Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org>
Fixes: 1308fb4e4eae14e6 ("pinctrl: rzn1: Do not select
GENERIC_PIN{CTRL_GROUPS,MUX_FUNCTIONS}")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-pinctrl-fixes-for-v6.6...
> --- a/drivers/pinctrl/renesas/Kconfig
> +++ b/drivers/pinctrl/renesas/Kconfig
> @@ -234,6 +234,7 @@ config PINCTRL_RZN1
> bool "pin control support for RZ/N1"
> depends on OF
> depends on ARCH_RZN1 || COMPILE_TEST
> + select PINMUX
> select GENERIC_PINCONF
... with alphabetical sort order restored.
No need to resend.
> help
> This selects pinctrl driver for Renesas RZ/N1 devices.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2023-10-05 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 20:00 [PATCH] pinctrl: renesas: rzn1: enable PINMUX Ralph Siemsen
2023-10-04 22:24 ` Miquel Raynal
2023-10-05 7:10 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVEhVX8bcCVNYRuzdOpiW64dBELJp0ncdYsZUg4LLFLeA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=ralph.siemsen@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).