linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon <horms@verge.net.au>,
	Linus Walleij <linus.walleij@linaro.org>,
	Magnus <magnus.damm@gmail.com>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: rcar: Enable r8a7795 for ARM64
Date: Tue, 25 Aug 2015 10:58:16 +0200	[thread overview]
Message-ID: <CAMuHMdVGZyM7b3ONvrVF6-excdV094miUt97rSp-AVigH_CFoA@mail.gmail.com> (raw)
In-Reply-To: <8737z77ok8.wl%kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

On Tue, Aug 25, 2015 at 10:39 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> 8cd1470("gpio: rcar: Add r8a7795 (R-Car H3) support") adds
> GPIO support for r8a7795. r8a7795 based on CONFIG_ARM64.
> This patch enables r8a7795 on ARM64.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  drivers/gpio/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index b4fc9e4..5d083f7 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -356,7 +356,7 @@ config GPIO_PXA
>
>  config GPIO_RCAR
>         tristate "Renesas R-Car GPIO"
> -       depends on ARM && (ARCH_SHMOBILE || COMPILE_TEST)
> +       depends on (ARM || ARM64) && (ARCH_SHMOBILE || COMPILE_TEST)

As this driver seems to compile fine on non-ARM, what about relaxing the
dependency to

    depends on ARCH_SHMOBILE || COMPILE_TEST

instead?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2015-08-25  8:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25  8:39 [PATCH] gpio: rcar: Enable r8a7795 for ARM64 Kuninori Morimoto
2015-08-25  8:58 ` Geert Uytterhoeven [this message]
2015-08-25  9:15   ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMuHMdVGZyM7b3ONvrVF6-excdV094miUt97rSp-AVigH_CFoA@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=gnurou@gmail.com \
    --cc=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).