From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [RFC] pinctrl: sh-pfc: only use dummy states for non-DT platforms Date: Wed, 9 Mar 2016 14:17:57 +0100 Message-ID: References: <1457376072-755-1-git-send-email-wsa@the-dreams.de> <56DDDE6E.6090908@cogentembedded.com> <56DDE5CB.60204@cogentembedded.com> <20160309095805.GA1506@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org To: Linus Walleij Cc: Wolfram Sang , Sergei Shtylyov , linux-renesas-soc@vger.kernel.org, Laurent Pinchart , Kuninori Morimoto , Magnus Damm , Geert Uytterhoeven , "linux-gpio@vger.kernel.org" , Shawn Guo , Sascha Hauer List-Id: linux-gpio@vger.kernel.org Hi Linus, On Wed, Mar 9, 2016 at 11:32 AM, Linus Walleij wrote: > On Wed, Mar 9, 2016 at 4:58 PM, Wolfram Sang wrote: >> On Mon, Mar 07, 2016 at 10:00:37PM +0100, Geert Uytterhoeven wrote: > >>> > This approach is better then, won't have to fix again whenever SH gets DT >>> > support. >>> >>> Perhaps the of_have_populated_dt() check should be moved inside >>> pinctrl_provide_dummies()? >> >> I suggest we pick up this patch now even with stable tag (the irq storm >> fixup doesn't work correctly because of this) and consider the >> refactoring as a second step? > > Sergei, Geert, do you ACK this? I gave this a try on all my boards, plus the remote r8a7790/lager that exhibited the problem. Tested-by: Geert Uytterhoeven Please pick it up. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds