[PATCH] pinctrl: renesas: rzg2l: Suppress binding attributes

[PATCH] pinctrl: renesas: rzg2l: Suppress binding attributes

[Claudiu]

From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Suppress binding attributes for the rzg2l pinctrl driver, as it is an
essential block for Renesas SoCs. Unbinding the driver leads to warnings
from __device_links_no_driver() and can eventually render the system
inaccessible.

Fixes: c4c4637eb57f ("pinctrl: renesas: Add RZ/G2L pin and gpio controller driver")
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
---
 drivers/pinctrl/renesas/pinctrl-rzg2l.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
index ce4a07a3df49..5f006a059d9c 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -3386,6 +3386,7 @@ static struct platform_driver rzg2l_pinctrl_driver = {
 		.name = DRV_NAME,
 		.of_match_table = of_match_ptr(rzg2l_pinctrl_of_table),
 		.pm = pm_sleep_ptr(&rzg2l_pinctrl_pm_ops),
+		.suppress_bind_attrs = true,
 	},
 	.probe = rzg2l_pinctrl_probe,
 };
-- 
2.43.0

Re: [PATCH] pinctrl: renesas: rzg2l: Suppress binding attributes

[Lad, Prabhakar]

On Sat, Feb 15, 2025 at 1:12 PM Claudiu <claudiu.beznea@tuxon.dev> wrote:
>
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Suppress binding attributes for the rzg2l pinctrl driver, as it is an
> essential block for Renesas SoCs. Unbinding the driver leads to warnings
> from __device_links_no_driver() and can eventually render the system
> inaccessible.
>
> Fixes: c4c4637eb57f ("pinctrl: renesas: Add RZ/G2L pin and gpio controller driver")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
>  drivers/pinctrl/renesas/pinctrl-rzg2l.c | 1 +
>  1 file changed, 1 insertion(+)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> index ce4a07a3df49..5f006a059d9c 100644
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -3386,6 +3386,7 @@ static struct platform_driver rzg2l_pinctrl_driver = {
>                 .name = DRV_NAME,
>                 .of_match_table = of_match_ptr(rzg2l_pinctrl_of_table),
>                 .pm = pm_sleep_ptr(&rzg2l_pinctrl_pm_ops),
> +               .suppress_bind_attrs = true,
>         },
>         .probe = rzg2l_pinctrl_probe,
>  };
> --
> 2.43.0
>
>

Re: [PATCH] pinctrl: renesas: rzg2l: Suppress binding attributes

[Geert Uytterhoeven]

On Sat, 15 Feb 2025 at 14:12, Claudiu <claudiu.beznea@tuxon.dev> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Suppress binding attributes for the rzg2l pinctrl driver, as it is an
> essential block for Renesas SoCs. Unbinding the driver leads to warnings
> from __device_links_no_driver() and can eventually render the system
> inaccessible.
>
> Fixes: c4c4637eb57f ("pinctrl: renesas: Add RZ/G2L pin and gpio controller driver")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-pinctrl for v6.15.

>  drivers/pinctrl/renesas/pinctrl-rzg2l.c | 1 +

Looks like there are more opportunities for similar changes?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds