[PATCH] gpio: rcar: Add R8A7743 (RZ/G1M) support

linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] gpio: rcar: Add R8A7743 (RZ/G1M) support
@ 2017-06-16 13:32 Biju Das
  2017-06-16 17:24 ` Sergei Shtylyov
  2017-06-21 14:27 ` [PATCH v2] " Biju Das
  0 siblings, 2 replies; 8+ messages in thread
From: Biju Das @ 2017-06-16 13:32 UTC (permalink / raw)
  To: Linus Walleij, Mark Rutland, Alexandre Courbot
  Cc: Simon Horman, Magnus Damm, Russell King, Chris Paterson,
	linux-gpio, devicetree, linux-renesas-soc, linux-arm-kernel,
	Biju Das

Renesas RZ/G1M (R8A7743 SoC) GPIO blocks are identical to the R-Car Gen2
family. Add support for its GPIO controllers.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
---
 Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 1 +
 drivers/gpio/gpio-rcar.c                                     | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
index 7c1ab3b..1cc3cfe 100644
--- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
+++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
@@ -3,6 +3,7 @@
 Required Properties:
 
   - compatible: should contain one of the following.
+    - "renesas,gpio-r8a7743": for R8A7743 (RZ-G1M) compatible GPIO controller.
     - "renesas,gpio-r8a7778": for R8A7778 (R-Mobile M1) compatible GPIO controller.
     - "renesas,gpio-r8a7779": for R8A7779 (R-Car H1) compatible GPIO controller.
     - "renesas,gpio-r8a7790": for R8A7790 (R-Car H2) compatible GPIO controller.
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 31ad288..4a1536a 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -344,6 +344,10 @@ struct gpio_rcar_info {
 
 static const struct of_device_id gpio_rcar_of_table[] = {
 	{
+		.compatible = "renesas,gpio-r8a7743",
+		/* RZ/G1 GPIO is identical to R-Car Gen2. */
+		.data = &gpio_rcar_info_gen2,
+	}, {
 		.compatible = "renesas,gpio-r8a7790",
 		.data = &gpio_rcar_info_gen2,
 	}, {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] gpio: rcar: Add R8A7743 (RZ/G1M) support
  2017-06-16 13:32 [PATCH] gpio: rcar: Add R8A7743 (RZ/G1M) support Biju Das
@ 2017-06-16 17:24 ` Sergei Shtylyov
  2017-06-19 11:17   ` Biju Das
  2017-06-21 14:27 ` [PATCH v2] " Biju Das
  1 sibling, 1 reply; 8+ messages in thread
From: Sergei Shtylyov @ 2017-06-16 17:24 UTC (permalink / raw)
  To: Biju Das, Linus Walleij, Mark Rutland, Alexandre Courbot
  Cc: Simon Horman, Magnus Damm, Russell King, Chris Paterson,
	linux-gpio, devicetree, linux-renesas-soc, linux-arm-kernel

Hello!

On 06/16/2017 04:32 PM, Biju Das wrote:

> Renesas RZ/G1M (R8A7743 SoC) GPIO blocks are identical to the R-Car Gen2

    SoC should be outside the parens.

> family. Add support for its GPIO controllers.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> ---
>  Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 1 +
>  drivers/gpio/gpio-rcar.c                                     | 4 ++++
>  2 files changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
> index 7c1ab3b..1cc3cfe 100644
> --- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
> +++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
> @@ -3,6 +3,7 @@
>  Required Properties:
>
>    - compatible: should contain one of the following.
> +    - "renesas,gpio-r8a7743": for R8A7743 (RZ-G1M) compatible GPIO controller.

    Not RZ/G1M?

[...]

MBR, Sergei

^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [PATCH] gpio: rcar: Add R8A7743 (RZ/G1M) support
  2017-06-16 17:24 ` Sergei Shtylyov
@ 2017-06-19 11:17   ` Biju Das
  0 siblings, 0 replies; 8+ messages in thread
From: Biju Das @ 2017-06-19 11:17 UTC (permalink / raw)
  To: Sergei Shtylyov, Linus Walleij, Mark Rutland, Alexandre Courbot
  Cc: Simon Horman, Magnus Damm, Russell King, Chris Paterson,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org

> Subject: Re: [PATCH] gpio: rcar: Add R8A7743 (RZ/G1M) support
>
> Hello!
>
> On 06/16/2017 04:32 PM, Biju Das wrote:
>
> > Renesas RZ/G1M (R8A7743 SoC) GPIO blocks are identical to the R-Car
> Gen2
>
>     SoC should be outside the parens.

Thanks. I will correct it.

>
> > family. Add support for its GPIO controllers.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> > ---
> >  Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 1 +
> >  drivers/gpio/gpio-rcar.c                                     | 4 ++++
> >  2 files changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
> b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
> > index 7c1ab3b..1cc3cfe 100644
> > --- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
> > +++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
> > @@ -3,6 +3,7 @@
> >  Required Properties:
> >
> >    - compatible: should contain one of the following.
> > +    - "renesas,gpio-r8a7743": for R8A7743 (RZ-G1M) compatible GPIO
> controller.
>
>     Not RZ/G1M?

I will change this to RZ/G1M and will push V2.

Regards,
Biju



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2] gpio: rcar: Add R8A7743 (RZ/G1M) support
  2017-06-16 13:32 [PATCH] gpio: rcar: Add R8A7743 (RZ/G1M) support Biju Das
  2017-06-16 17:24 ` Sergei Shtylyov
@ 2017-06-21 14:27 ` Biju Das
       [not found]   ` <1498055229-42052-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
  1 sibling, 1 reply; 8+ messages in thread
From: Biju Das @ 2017-06-21 14:27 UTC (permalink / raw)
  To: Linus Walleij, Alexandre Courbot, Rob Herring, Mark Rutland
  Cc: Sergei Shtylyov, Simon Horman, Magnus Damm, Russell King,
	Chris Paterson, linux-gpio, devicetree, linux-renesas-soc,
	linux-arm-kernel, Biju Das

Renesas RZ/G1M (R8A7743) SoC GPIO blocks are identical to the R-Car Gen2
family. Add support for its GPIO controllers.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
---
v1->v2
* Modified the text "RZ-G1M" to "RZ/G1M"

 Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 1 +
 drivers/gpio/gpio-rcar.c                                     | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
index 7c1ab3b..6826a37 100644
--- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
+++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
@@ -3,6 +3,7 @@
 Required Properties:
 
   - compatible: should contain one of the following.
+    - "renesas,gpio-r8a7743": for R8A7743 (RZ/G1M) compatible GPIO controller.
     - "renesas,gpio-r8a7778": for R8A7778 (R-Mobile M1) compatible GPIO controller.
     - "renesas,gpio-r8a7779": for R8A7779 (R-Car H1) compatible GPIO controller.
     - "renesas,gpio-r8a7790": for R8A7790 (R-Car H2) compatible GPIO controller.
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 31ad288..4a1536a 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -344,6 +344,10 @@ struct gpio_rcar_info {
 
 static const struct of_device_id gpio_rcar_of_table[] = {
 	{
+		.compatible = "renesas,gpio-r8a7743",
+		/* RZ/G1 GPIO is identical to R-Car Gen2. */
+		.data = &gpio_rcar_info_gen2,
+	}, {
 		.compatible = "renesas,gpio-r8a7790",
 		.data = &gpio_rcar_info_gen2,
 	}, {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

[parent not found: <1498055229-42052-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>]

* Re: [PATCH v2] gpio: rcar: Add R8A7743 (RZ/G1M) support
       [not found]   ` <1498055229-42052-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
@ 2017-06-26  8:13     ` Geert Uytterhoeven
  2017-06-26 17:40       ` Simon Horman
  2017-06-26 18:04     ` Rob Herring
  2017-06-29 12:23     ` Linus Walleij
  2 siblings, 1 reply; 8+ messages in thread
From: Geert Uytterhoeven @ 2017-06-26  8:13 UTC (permalink / raw)
  To: Biju Das
  Cc: Linus Walleij, Alexandre Courbot, Rob Herring, Mark Rutland,
	Sergei Shtylyov, Simon Horman, Magnus Damm, Russell King,
	Chris Paterson,
	linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux-Renesas,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org

On Wed, Jun 21, 2017 at 4:27 PM, Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> wrote:
> Renesas RZ/G1M (R8A7743) SoC GPIO blocks are identical to the R-Car Gen2
> family. Add support for its GPIO controllers.
>
> Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> Reviewed-by: Chris Paterson <chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

Acked-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Although I think the time has come for family-specific compatible values
for R-Car Gen2 and Gen3.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] gpio: rcar: Add R8A7743 (RZ/G1M) support
  2017-06-26  8:13     ` Geert Uytterhoeven
@ 2017-06-26 17:40       ` Simon Horman
  0 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2017-06-26 17:40 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Biju Das, Linus Walleij, Alexandre Courbot, Rob Herring,
	Mark Rutland, Sergei Shtylyov, Magnus Damm, Russell King,
	Chris Paterson, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, Linux-Renesas,
	linux-arm-kernel@lists.infradead.org

On Mon, Jun 26, 2017 at 10:13:00AM +0200, Geert Uytterhoeven wrote:
> On Wed, Jun 21, 2017 at 4:27 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> > Renesas RZ/G1M (R8A7743) SoC GPIO blocks are identical to the R-Car Gen2
> > family. Add support for its GPIO controllers.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> 
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Although I think the time has come for family-specific compatible values
> for R-Car Gen2 and Gen3.

Yes, agreed.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] gpio: rcar: Add R8A7743 (RZ/G1M) support
       [not found]   ` <1498055229-42052-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
  2017-06-26  8:13     ` Geert Uytterhoeven
@ 2017-06-26 18:04     ` Rob Herring
  2017-06-29 12:23     ` Linus Walleij
  2 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2017-06-26 18:04 UTC (permalink / raw)
  To: Biju Das
  Cc: Linus Walleij, Alexandre Courbot, Mark Rutland, Sergei Shtylyov,
	Simon Horman, Magnus Damm, Russell King, Chris Paterson,
	linux-gpio-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

On Wed, Jun 21, 2017 at 03:27:09PM +0100, Biju Das wrote:
> Renesas RZ/G1M (R8A7743) SoC GPIO blocks are identical to the R-Car Gen2
> family. Add support for its GPIO controllers.
> 
> Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> Reviewed-by: Chris Paterson <chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> ---
> v1->v2
> * Modified the text "RZ-G1M" to "RZ/G1M"
> 
>  Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 1 +
>  drivers/gpio/gpio-rcar.c                                     | 4 ++++
>  2 files changed, 5 insertions(+)

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] gpio: rcar: Add R8A7743 (RZ/G1M) support
       [not found]   ` <1498055229-42052-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
  2017-06-26  8:13     ` Geert Uytterhoeven
  2017-06-26 18:04     ` Rob Herring
@ 2017-06-29 12:23     ` Linus Walleij
  2 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2017-06-29 12:23 UTC (permalink / raw)
  To: Biju Das
  Cc: Alexandre Courbot, Rob Herring, Mark Rutland, Sergei Shtylyov,
	Simon Horman, Magnus Damm, Russell King, Chris Paterson,
	linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux-Renesas,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org

On Wed, Jun 21, 2017 at 4:27 PM, Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> wrote:

> Renesas RZ/G1M (R8A7743) SoC GPIO blocks are identical to the R-Car Gen2
> family. Add support for its GPIO controllers.
>
> Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> Reviewed-by: Chris Paterson <chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> ---
> v1->v2
> * Modified the text "RZ-G1M" to "RZ/G1M"

Patch applied with the ACKs.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-06-29 12:23 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-16 13:32 [PATCH] gpio: rcar: Add R8A7743 (RZ/G1M) support Biju Das
2017-06-16 17:24 ` Sergei Shtylyov
2017-06-19 11:17   ` Biju Das
2017-06-21 14:27 ` [PATCH v2] " Biju Das
     [not found]   ` <1498055229-42052-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-06-26  8:13     ` Geert Uytterhoeven
2017-06-26 17:40       ` Simon Horman
2017-06-26 18:04     ` Rob Herring
2017-06-29 12:23     ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).